Merge pull request #3144 from nextcloud/use-data-download-response
Use DataDownloadResponse
This commit is contained in:
commit
8565011b8d
|
@ -446,8 +446,7 @@ class ThemingController extends Controller {
|
|||
cacheBuster: ' . json_encode($cacheBusterValue). '
|
||||
};
|
||||
})();';
|
||||
$response = new Http\DataDisplayResponse($responseJS);
|
||||
$response->addHeader('Content-type', 'text/javascript');
|
||||
$response = new DataDownloadResponse($responseJS, 'javascript', 'text/javascript');
|
||||
$response->addHeader('Expires', date(\DateTime::RFC2822, $this->timeFactory->getTime()));
|
||||
$response->addHeader('Pragma', 'cache');
|
||||
$response->cacheFor(3600);
|
||||
|
|
|
@ -914,7 +914,6 @@ class ThemingControllerTest extends TestCase {
|
|||
'background-image: url(\'./img/core/filetypes/folder.svg?v=0\');' . "}\n" .
|
||||
'.icon-filetype-folder-drag-accept {' .
|
||||
'background-image: url(\'./img/core/filetypes/folder-drag-accept.svg?v=0\')!important;' . "}\n";
|
||||
$expected = new Http\DataDownloadResponse($expectedData, 'style', 'text/css');
|
||||
|
||||
$expected = new Http\DataDownloadResponse($expectedData, 'style', 'text/css');
|
||||
$expected->cacheFor(3600);
|
||||
|
@ -952,8 +951,7 @@ class ThemingControllerTest extends TestCase {
|
|||
cacheBuster: null
|
||||
};
|
||||
})();';
|
||||
$expected = new Http\DataDisplayResponse($expectedResponse);
|
||||
$expected->addHeader("Content-type","text/javascript");
|
||||
$expected = new Http\DataDownloadResponse($expectedResponse, 'javascript', 'text/javascript');
|
||||
$expected->addHeader('Expires', date(\DateTime::RFC2822, $this->timeFactory->getTime()));
|
||||
$expected->addHeader('Pragma', 'cache');
|
||||
$expected->cacheFor(3600);
|
||||
|
@ -987,8 +985,7 @@ class ThemingControllerTest extends TestCase {
|
|||
cacheBuster: null
|
||||
};
|
||||
})();';
|
||||
$expected = new Http\DataDisplayResponse($expectedResponse);
|
||||
$expected->addHeader("Content-type","text/javascript");
|
||||
$expected = new Http\DataDownloadResponse($expectedResponse, 'javascript', 'text/javascript');
|
||||
$expected->addHeader('Expires', date(\DateTime::RFC2822, $this->timeFactory->getTime()));
|
||||
$expected->addHeader('Pragma', 'cache');
|
||||
$expected->cacheFor(3600);
|
||||
|
|
Loading…
Reference in New Issue