mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unused properties in ShareesAPIController 

Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl 2020-02-18 19:43:26 +01:00
parent 381decca49
commit 87393a760e
2 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
apps/files_sharing/lib/Controller/ShareesAPIController.php
View File

@ -66,12 +66,6 @@ class ShareesAPIController extends OCSController {
/** @var IManager */ /** @var IManager */
protected $shareManager; protected $shareManager;
/** @var bool */
protected $shareWithGroupOnly = false;
/** @var bool */
protected $shareeEnumeration = true;
/** @var int */ /** @var int */
protected $offset = 0; protected $offset = 0;
@ -205,8 +199,6 @@ class ShareesAPIController extends OCSController {
} }
sort($shareTypes); sort($shareTypes);
$this->shareWithGroupOnly = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members', 'no') === 'yes';
$this->shareeEnumeration = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
$this->limit = (int) $perPage; $this->limit = (int) $perPage;
$this->offset = $perPage * ($page - 1); $this->offset = $perPage * ($page - 1);

7
apps/files_sharing/tests/Controller/ShareesAPIControllerTest.php
View File

@ -237,12 +237,10 @@ class ShareesAPIControllerTest extends TestCase {
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */ /** @var IConfig|\PHPUnit_Framework_MockObject_MockObject $config */
$config = $this->createMock(IConfig::class); $config = $this->createMock(IConfig::class);
$config->expects($this->exactly(3)) $config->expects($this->exactly(1))
->method('getAppValue') ->method('getAppValue')
->with($this->anything(), $this->anything(), $this->anything()) ->with($this->anything(), $this->anything(), $this->anything())
->willReturnMap([ ->willReturnMap([
['core', 'shareapi_only_share_with_group_members', 'no', $apiSetting],
['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes', $enumSetting],
['files_sharing', 'lookupServerEnabled', 'yes', 'yes'], ['files_sharing', 'lookupServerEnabled', 'yes', 'yes'],
]); ]);
@ -302,9 +300,6 @@ class ShareesAPIControllerTest extends TestCase {
})); }));
$this->assertInstanceOf(Http\DataResponse::class, $sharees->search($search, $itemType, $page, $perPage, $shareType)); $this->assertInstanceOf(Http\DataResponse::class, $sharees->search($search, $itemType, $page, $perPage, $shareType));
$this->assertSame($shareWithGroupOnly, $this->invokePrivate($sharees, 'shareWithGroupOnly'));
$this->assertSame($shareeEnumeration, $this->invokePrivate($sharees, 'shareeEnumeration'));
} }
public function dataSearchInvalid() { public function dataSearchInvalid() {