From 8acbb7aef971912c445346423d342bb049190a1e Mon Sep 17 00:00:00 2001
From: Arthur Schiwon <blizzz@owncloud.com>
Date: Thu, 3 Dec 2015 21:53:58 +0100
Subject: [PATCH] rework test about overwriting default comments manager

---
 tests/lib/comments/fakefactory.php | 21 +++----------------
 tests/lib/comments/fakemanager.php | 33 ++++++++++++++++++++++++++++++
 tests/lib/server.php               | 12 +++++++++++
 3 files changed, 48 insertions(+), 18 deletions(-)
 create mode 100644 tests/lib/comments/fakemanager.php

diff --git a/tests/lib/comments/fakefactory.php b/tests/lib/comments/fakefactory.php
index 0fa68e4cb0..837bcb1058 100644
--- a/tests/lib/comments/fakefactory.php
+++ b/tests/lib/comments/fakefactory.php
@@ -2,27 +2,12 @@
 
 namespace Test\Comments;
 
-use Test\TestCase;
-
 /**
- * Class Test_Comments_FakeFactory
+ * Class FakeFactory
  */
-class Test_Comments_FakeFactory extends TestCase implements \OCP\Comments\ICommentsManagerFactory {
+class FakeFactory implements \OCP\Comments\ICommentsManagerFactory {
 
 	public function getManager() {
-		return $this->getMock('\OCP\Comments\ICommentsManager');
-	}
-
-	public function testOverwriteDefaultManager() {
-		$config = \OC::$server->getConfig();
-		$defaultManagerFactory = $config->getSystemValue('comments.managerFactory', '\OC\Comments\ManagerFactory');
-
-		$managerMock = $this->getMock('\OCP\Comments\ICommentsManager');
-
-		$config->setSystemValue('comments.managerFactory', '\Test\Comments\Test_Comments_FakeFactory');
-		$manager = \OC::$server->getCommentsManager();
-		$this->assertEquals($managerMock, $manager);
-
-		$config->setSystemValue('comments.managerFactory', $defaultManagerFactory);
+		return new FakeManager();
 	}
 }
diff --git a/tests/lib/comments/fakemanager.php b/tests/lib/comments/fakemanager.php
new file mode 100644
index 0000000000..a3cd9c0c06
--- /dev/null
+++ b/tests/lib/comments/fakemanager.php
@@ -0,0 +1,33 @@
+<?php
+
+namespace Test\Comments;
+
+/**
+ * Class FakeManager
+ */
+class FakeManager implements \OCP\Comments\ICommentsManager {
+
+	public function get($id) {}
+
+	public function getTree($id, $limit = 0, $offset = 0) {}
+
+	public function getForObject(
+		$objectType,
+		$objectId,
+		$limit = 0,
+		$offset = 0,
+		\DateTime $notOlderThan = null
+	) {}
+
+	public function getNumberOfCommentsForObject($objectType, $objectId) {}
+
+	public function create($actorType, $actorId, $objectType, $objectId) {}
+
+	public function delete($id) {}
+
+	public function save(\OCP\Comments\IComment &$comment) {}
+
+	public function deleteReferencesOfActor($actorType, $actorId) {}
+
+	public function deleteCommentsAtObject($objectType, $objectId) {}
+}
diff --git a/tests/lib/server.php b/tests/lib/server.php
index 0bee19822d..6b569e77dd 100644
--- a/tests/lib/server.php
+++ b/tests/lib/server.php
@@ -174,4 +174,16 @@ class Server extends \Test\TestCase {
 		$this->assertInstanceOf('\OC_EventSource', $this->server->createEventSource(), 'service returned by "createEventSource" did not return the right class');
 		$this->assertInstanceOf('\OCP\IEventSource', $this->server->createEventSource(), 'service returned by "createEventSource" did not return the right class');
 	}
+
+	public function testOverwriteDefaultCommentsManager() {
+		$config = $this->server->getConfig();
+		$defaultManagerFactory = $config->getSystemValue('comments.managerFactory', '\OC\Comments\ManagerFactory');
+
+		$config->setSystemValue('comments.managerFactory', '\Test\Comments\FakeFactory');
+
+		$manager = $this->server->getCommentsManager();
+		$this->assertInstanceOf('\OCP\Comments\ICommentsManager', $manager);
+
+		$config->setSystemValue('comments.managerFactory', $defaultManagerFactory);
+	}
 }