diff --git a/index.php b/index.php index 40063fa6e0..0a2f15f9f5 100755 --- a/index.php +++ b/index.php @@ -30,8 +30,9 @@ try { OC::handleRequest(); } catch (Exception $ex) { + \OCP\Util::logException('index', $ex); + //show the user a detailed error page - \OCP\Util::writeLog('index', $ex->getMessage(), \OCP\Util::FATAL); OC_Response::setStatus(OC_Response::STATUS_INTERNAL_SERVER_ERROR); OC_Template::printExceptionErrorPage($ex); } diff --git a/lib/public/util.php b/lib/public/util.php index b33f07b55e..ed0622b8d1 100644 --- a/lib/public/util.php +++ b/lib/public/util.php @@ -77,6 +77,39 @@ class Util { \OC_LOG::write( $app, $message, $level ); } + /** + * @brief write exception into the log. Include the stack trace + * if DEBUG mode is enabled + * @param Exception $ex exception to log + */ + public static function logException( $app, \Exception $ex ) { + $message = $ex->getMessage(); + if ($ex->getCode()) { + $message .= ' [' . $ex->getCode() . ']'; + } + \OCP\Util::writeLog($app, 'Exception: ' . $message, \OCP\Util::FATAL); + if (defined('DEBUG') and DEBUG) { + // also log stack trace + $stack = explode('#', $ex->getTraceAsString()); + // first element is empty + array_shift($stack); + foreach ($stack as $s) { + \OCP\Util::writeLog($app, 'Exception: ' . $s, \OCP\Util::FATAL); + } + + // include cause + $l = \OC_L10N::get('lib'); + while (method_exists($ex, 'getPrevious') && $ex = $ex->getPrevious()) { + $message .= ' - '.$l->t('Caused by:').' '; + $message .= $ex->getMessage(); + if ($ex->getCode()) { + $message .= '[' . $ex->getCode() . '] '; + } + \OCP\Util::writeLog($app, 'Exception: ' . $message, \OCP\Util::FATAL); + } + } + } + /** * @brief get l10n object * @param string $app