mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

split walking the tree from operating on it 

so walking it is reusable

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This commit is contained in:
Arthur Schiwon 2017-10-11 17:08:45 +02:00
parent fd6daf8d19
commit 8f0a9ae51f
No known key found for this signature in database
GPG Key ID: 7424F1874854DF23
1 changed files with 25 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
lib/private/Comments/Manager.php
View File

@ -340,12 +340,12 @@ class Manager implements ICommentsManager {
public function getActorsInTree($id) { public function getActorsInTree($id) {
$tree = $this->getTree($id); $tree = $this->getTree($id);
$actors = []; $actors = [];
$this->extractActor($tree, $actors); $this->walkTree($tree, $actors, [$this, 'extractActor']);
return $actors; return $actors;
} }
/** /**
* @param array $node * @param IComment $comment
* @param array &$actors * @param array &$actors
* *
* build an array that looks like: * build an array that looks like:
@ -362,23 +362,34 @@ class Manager implements ICommentsManager {
* ] * ]
* *
*/ */
protected function extractActor(array $node, array &$actors) { protected function extractActor(IComment $comment, &$actors) {
if(!isset($actors[$comment->getActorType()])) {
$actors[$comment->getActorType()] = [];
}
if(!isset($actors[$comment->getActorType()][$comment->getActorId()])) {
$actors[$comment->getActorType()][$comment->getActorId()] = 1;
} else {
$actors[$comment->getActorType()][$comment->getActorId()] += 1;
}
}
/**
* walks through a comment tree (as returned by getTree() and invokes a callback
* with the current IComment instance (and optionally custom parameters)
*
* @param array $node
* @param array &$results
* @param callable $callback
* @param array|null $parameters
*/
protected function walkTree($node, array &$results, callable $callback, array $parameters = null) {
if(isset($node['replies'])) { if(isset($node['replies'])) {
foreach ($node['replies'] as $subNode) { foreach ($node['replies'] as $subNode) {
$this->extractActor($subNode, $actors); $this->walkTree($subNode, $results, $callback, $parameters);
} }
} }
if(isset($node['comment']) && $node['comment'] instanceof IComment) { if(isset($node['comment']) && $node['comment'] instanceof IComment) {
/** @var IComment $comment */ $callback($node['comment'], $results, $parameters);
$comment = $node['comment'];
if(!isset($actors[$comment->getActorType()])) {
$actors[$comment->getActorType()] = [];
}
if(!isset($actors[$comment->getActorType()][$comment->getActorId()])) {
$actors[$comment->getActorType()][$comment->getActorId()] = 1;
} else {
$actors[$comment->getActorType()][$comment->getActorId()] += 1;
}
} }
} }