Merge pull request #11790 from nextcloud/backport/11745/stable14

[14] php7.3 CI

.drone.yml

@@ -66,6 +66,22 @@ pipeline:
     when:
       matrix:
         TESTS: syntax-php7.1
+  syntax-php7.2:
+    image: nextcloudci/php7.2:php7.2-12
+    commands:
+      - composer install
+      - ./lib/composer/bin/parallel-lint --exclude lib/composer/jakub-onderka/ --exclude 3rdparty/symfony/polyfill-php70/Resources/stubs/ --exclude 3rdparty/patchwork/utf8/src/Patchwork/Utf8/Bootup/ --exclude 3rdparty/paragonie/random_compat/lib/ --exclude lib/composer/composer/autoload_static.php --exclude 3rdparty/composer/autoload_static.php --exclude 3rdparty/doctrine/cache/lib/Doctrine/Common/Cache/RiakCache.php .
+    when:
+      matrix:
+        TESTS: syntax-php7.2
+  syntax-php7.3:
+    image: nextcloudci/php7.3:php7.3-1
+    commands:
+      - composer install
+      - ./lib/composer/bin/parallel-lint --exclude lib/composer/jakub-onderka/ --exclude 3rdparty/symfony/polyfill-php70/Resources/stubs/ --exclude 3rdparty/patchwork/utf8/src/Patchwork/Utf8/Bootup/ --exclude 3rdparty/paragonie/random_compat/lib/ --exclude lib/composer/composer/autoload_static.php --exclude 3rdparty/composer/autoload_static.php --exclude 3rdparty/doctrine/cache/lib/Doctrine/Common/Cache/RiakCache.php .
+    when:
+      matrix:
+        TESTS: syntax-php7.3
   phan:
     image: nextcloudci/php7.2:php7.2-12
     commands:
@@ -191,6 +207,14 @@ pipeline:
       matrix:
         DB: NODB
         PHP: 7.2
+  nodb-php7.3:
+    image: nextcloudci/php7.3:php7.3-1
+    commands:
+      - NOCOVERAGE=true TEST_SELECTION=NODB ./autotest.sh sqlite
+    when:
+      matrix:
+        DB: NODB
+        PHP: 7.3
   sqlite-php7.0:
     image: nextcloudci/php7.0:php7.0-19
     commands:
@@ -215,6 +239,14 @@ pipeline:
       matrix:
         DB: sqlite
         PHP: 7.2
+  sqlite-php7.3:
+    image: nextcloudci/php7.3:php7.3-1
+    commands:
+      - NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh sqlite
+    when:
+      matrix:
+        DB: sqlite
+        PHP: 7.3
   mysql-php7.0:
     image: nextcloudci/php7.0:php7.0-19
     commands:
@@ -239,6 +271,14 @@ pipeline:
       matrix:
         DB: mysql
         PHP: 7.2
+  mysql-php7.3:
+    image: nextcloudci/php7.3:php7.3-1
+    commands:
+      - NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysql
+    when:
+      matrix:
+        DB: mysql
+        PHP: 7.3
   mysql5.6-php7.0:
     image: nextcloudci/php7.0:php7.0-19
     commands:
@@ -313,6 +353,14 @@ pipeline:
       matrix:
         DB: mysqlmb4
         PHP: 7.2
+  mysqlmb4-php7.3:
+    image: nextcloudci/php7.3:php7.3-1
+    commands:
+      - NOCOVERAGE=true TEST_SELECTION=DB ./autotest.sh mysqlmb4
+    when:
+      matrix:
+        DB: mysqlmb4
+        PHP: 7.3
   integration-capabilities_features:
     image: nextcloudci/integration-php7.0:integration-php7.0-8
     commands:
@@ -769,6 +817,9 @@ matrix:
     - DB: NODB
       PHP: 7.2
       ENABLE_REDIS: false
+    - DB: NODB
+      PHP: 7.3
+      ENABLE_REDIS: false
     - DB: sqlite
       PHP: 7.0
       ENABLE_REDIS: true
@@ -778,6 +829,9 @@ matrix:
     - DB: sqlite
       PHP: 7.2
       ENABLE_REDIS: false
+    - DB: sqlite
+      PHP: 7.3
+      ENABLE_REDIS: false
     - DB: mysql
       PHP: 7.0
       ENABLE_REDIS: true
@@ -787,6 +841,9 @@ matrix:
     - DB: mysql
       PHP: 7.2
       ENABLE_REDIS: false
+    - DB: mysql
+      PHP: 7.3
+      ENABLE_REDIS: false
     - DB: mysql5.6
       PHP: 7.0
       ENABLE_REDIS: true
@@ -820,6 +877,9 @@ matrix:
     - DB: mysqlmb4
       PHP: 7.2
       ENABLE_REDIS: false
+    - DB: mysqlmb4
+      PHP: 7.3
+      ENABLE_REDIS: false
     - TESTS: integration-capabilities_features
     - TESTS: integration-federation_features
     - TESTS: integration-maintenance-mode
@@ -874,6 +934,8 @@ matrix:
     - TESTS: jsunit
     - TESTS: syntax-php7.0
     - TESTS: syntax-php7.1
+    - TESTS: syntax-php7.2
+    - TESTS: syntax-php7.3
     - TESTS: phan
     - TESTS: litmus-v1
     - TESTS: litmus-v2

lib/versioncheck.php

@@ -9,10 +9,10 @@ if (version_compare(PHP_VERSION, '7.0') === -1) {
 	exit(-1);
 }
 
-// Show warning if > PHP 7.2 is used as Nextcloud is not compatible with > PHP 7.2 for now
+// Show warning if > PHP 7.3 is used as Nextcloud is not compatible with > PHP 7.3 for now
-if (version_compare(PHP_VERSION, '7.3.0') !== -1) {
+if (version_compare(PHP_VERSION, '7.4.0') !== -1) {
 	http_response_code(500);
-	echo 'This version of Nextcloud is not compatible with > PHP 7.2.<br/>';
+	echo 'This version of Nextcloud is not compatible with > PHP 7.3.<br/>';
 	echo 'You are currently running ' . PHP_VERSION . '.';
 	exit(-1);
 }