mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix file permissions for SMB (read-only folders will be writeable) (#25301) 

* Fix file permissions for SMB (read-only folders will be writeable)

* Read-only folders won't be deletable

* Added comment for the read-only behaviour for folders
This commit is contained in:
Juan Pablo Villafañez 2016-07-20 14:22:04 +02:00 committed by Robin Appelman
parent f4f43dddf5
commit 91c6c451f4
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
apps/files_external/lib/Lib/Storage/SMB.php
View File

@ -395,6 +395,19 @@ class SMB extends Common implements INotifyStorage {
} }
public function isUpdatable($path) { public function isUpdatable($path) {
try {
$info = $this->getFileInfo($path);
// following windows behaviour for read-only folders: they can be written into
// (https://support.microsoft.com/en-us/kb/326549 - "cause" section)
return !$info->isHidden() && (!$info->isReadOnly() || $this->is_dir($path));
} catch (NotFoundException $e) {
return false;
} catch (ForbiddenException $e) {
return false;
}
}
public function isDeletable($path) {
try { try {
$info = $this->getFileInfo($path); $info = $this->getFileInfo($path);
return !$info->isHidden() && !$info->isReadOnly(); return !$info->isHidden() && !$info->isReadOnly();