mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't force displayname if backend already provides one 

`\OC_User::loginWithApache` is used in combination with backend mechanisms like our SSO / SAML integration. Those can optionally already provide a displayname using other means. For example by mapping SAML attributes.

The current approach makes it however impossible for backends using `\OCP\Authentication\IApacheBackend` to set a displayname on their own. Because the display name will simply be overwritten with the loginname.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
This commit is contained in:
Lukas Reschke 2017-02-16 13:23:04 +01:00
parent f25c89461c
commit 92c74d2f9a
No known key found for this signature in database
GPG Key ID: B9F6980CF6E759B1
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/private/legacy/user.php
View File

@ -187,7 +187,18 @@ class OC_User {
if ($uid) { if ($uid) {
if (self::getUser() !== $uid) { if (self::getUser() !== $uid) {
self::setUserId($uid); self::setUserId($uid);
self::setDisplayName($uid); $setUidAsDisplayName = true;
if($backend instanceof \OCP\UserInterface
&& $backend->implementsActions(OC_User_Backend::GET_DISPLAYNAME)) {
$backendDisplayName = $backend->getDisplayName($uid);
if(is_string($backendDisplayName) && trim($backendDisplayName) !== '') {
$setUidAsDisplayName = false;
}
}
if($setUidAsDisplayName) {
self::setDisplayName($uid);
}
self::getUserSession()->setLoginName($uid); self::getUserSession()->setLoginName($uid);
$request = OC::$server->getRequest(); $request = OC::$server->getRequest();
self::getUserSession()->createSessionToken($request, $uid, $uid); self::getUserSession()->createSessionToken($request, $uid, $uid);