mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #15629 from owncloud/deprecate-potential-dangerous-methods 

Deprecate unused `\OCP\Response::sendFile`
This commit is contained in:
Lukas Reschke 2015-04-20 11:01:32 +02:00
parent 9cb260d310 a98b819366
commit 930ae11f8e
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/private/response.php
View File

@ -212,9 +212,10 @@ class OC_Response {
} }
/** /**
* Send file as response, checking and setting caching headers * Send file as response, checking and setting caching headers
* @param string $filepath of file to send * @param string $filepath of file to send
*/ * @deprecated 8.1.0 - Use \OCP\AppFramework\Http\StreamResponse or another AppFramework controller instead
*/
static public function sendFile($filepath) { static public function sendFile($filepath) {
$fp = fopen($filepath, 'rb'); $fp = fopen($filepath, 'rb');
if ($fp) { if ($fp) {

2
lib/public/response.php
View File

@ -37,6 +37,7 @@ namespace OCP;
/** /**
* This class provides convenient functions to send the correct http response headers * This class provides convenient functions to send the correct http response headers
* @since 4.0.0 * @since 4.0.0
* @deprecated 8.1.0 - Use AppFramework controllers instead and modify the response object
*/ */
class Response { class Response {
/** /**
@ -103,6 +104,7 @@ class Response {
* Send file as response, checking and setting caching headers * Send file as response, checking and setting caching headers
* @param string $filepath of file to send * @param string $filepath of file to send
* @since 4.0.0 * @since 4.0.0
* @deprecated 8.1.0 - Use \OCP\AppFramework\Http\StreamResponse or another AppFramework controller instead
*/ */
static public function sendFile( $filepath ) { static public function sendFile( $filepath ) {
\OC_Response::sendFile( $filepath ); \OC_Response::sendFile( $filepath );