From 934b18405a7991eeb1e9ec7606f0d3c322c1482b Mon Sep 17 00:00:00 2001 From: Florian Pritz Date: Fri, 23 Sep 2011 12:39:38 +0200 Subject: [PATCH] fix apps/bookmarks if oc_bookmarks_tags is empty If you have bookmarks, but there are no tags in oc_bookmarks_tags, the query doesn't return any results. Using a left join fixes this. Reference: http://stackoverflow.com/questions/3171276/select-multiple-tables-when-one-table-is-empty-in-mysql Signed-off-by: Florian Pritz --- apps/bookmarks/ajax/updateList.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/bookmarks/ajax/updateList.php b/apps/bookmarks/ajax/updateList.php index 67acb2190c..e9051a8dbf 100644 --- a/apps/bookmarks/ajax/updateList.php +++ b/apps/bookmarks/ajax/updateList.php @@ -70,7 +70,8 @@ $query = OC_DB::prepare(' ELSE \' \' END AS tags - FROM *PREFIX*bookmarks, *PREFIX*bookmarks_tags + FROM *PREFIX*bookmarks + LEFT JOIN *PREFIX*bookmarks_tags ON 1=1 WHERE (*PREFIX*bookmarks.id = *PREFIX*bookmarks_tags.bookmark_id OR *PREFIX*bookmarks.id NOT IN ( SELECT *PREFIX*bookmarks_tags.bookmark_id FROM *PREFIX*bookmarks_tags