From 9668405ec73e5fcf648b93e2ebfa217ac81518ea Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Wed, 7 Jan 2015 13:28:56 +0100 Subject: [PATCH] doc fixes and removal of unnecessary use statements --- apps/user_ldap/command/checkuser.php | 1 - apps/user_ldap/command/showremnants.php | 9 +++------ apps/user_ldap/lib/jobs/cleanup.php | 2 +- apps/user_ldap/lib/user/offlineuser.php | 2 +- apps/user_ldap/user_ldap.php | 2 +- 5 files changed, 6 insertions(+), 10 deletions(-) diff --git a/apps/user_ldap/command/checkuser.php b/apps/user_ldap/command/checkuser.php index f9065a7c8d..202855e485 100644 --- a/apps/user_ldap/command/checkuser.php +++ b/apps/user_ldap/command/checkuser.php @@ -15,7 +15,6 @@ use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; use OCA\user_ldap\lib\user\User; -use OCA\User_LDAP\lib\user\Manager; use OCA\User_LDAP\lib\User\DeletedUsersIndex; use OCA\User_LDAP\Mapping\UserMapping; use OCA\user_ldap\lib\Helper as LDAPHelper; diff --git a/apps/user_ldap/command/showremnants.php b/apps/user_ldap/command/showremnants.php index 5b7322e771..5cfab34ef9 100644 --- a/apps/user_ldap/command/showremnants.php +++ b/apps/user_ldap/command/showremnants.php @@ -9,25 +9,22 @@ namespace OCA\user_ldap\Command; use Symfony\Component\Console\Command\Command; -use Symfony\Component\Console\Input\InputArgument; use Symfony\Component\Console\Input\InputInterface; -use Symfony\Component\Console\Input\InputOption; use Symfony\Component\Console\Output\OutputInterface; use OCA\user_ldap\lib\user\DeletedUsersIndex; -use OCA\User_LDAP\lib\Connection; -use OCA\User_LDAP\Mapping\UserMapping; use OCP\IDateTimeFormatter; class ShowRemnants extends Command { - /** @var OCA\User_LDAP\lib\User\DeletedUsersIndex */ + /** @var \OCA\User_LDAP\lib\User\DeletedUsersIndex */ protected $dui; - /** @var OCP\IDateTimeFormatter */ + /** @var \OCP\IDateTimeFormatter */ protected $dateFormatter; /** * @param OCA\user_ldap\lib\user\DeletedUsersIndex $dui + * @param OCP\IDateTimeFormatter $dateFormatter */ public function __construct(DeletedUsersIndex $dui, IDateTimeFormatter $dateFormatter) { $this->dui = $dui; diff --git a/apps/user_ldap/lib/jobs/cleanup.php b/apps/user_ldap/lib/jobs/cleanup.php index b044f997aa..7209126c82 100644 --- a/apps/user_ldap/lib/jobs/cleanup.php +++ b/apps/user_ldap/lib/jobs/cleanup.php @@ -191,7 +191,7 @@ class CleanUp extends \OC\BackgroundJob\TimedJob { * @return int */ private function getOffset() { - return $this->ocConfig->getAppValue('user_ldap', 'cleanUpJobOffset', 0); + return intval($this->ocConfig->getAppValue('user_ldap', 'cleanUpJobOffset', 0)); } /** diff --git a/apps/user_ldap/lib/user/offlineuser.php b/apps/user_ldap/lib/user/offlineuser.php index e5c87fd23f..1833f4be96 100644 --- a/apps/user_ldap/lib/user/offlineuser.php +++ b/apps/user_ldap/lib/user/offlineuser.php @@ -67,7 +67,7 @@ class OfflineUser { */ protected $db; /** - * @var OCA\User_LDAP\Mapping\UserMapping + * @var \OCA\User_LDAP\Mapping\UserMapping */ protected $mapping; diff --git a/apps/user_ldap/user_ldap.php b/apps/user_ldap/user_ldap.php index f9a39ddca1..051e760105 100644 --- a/apps/user_ldap/user_ldap.php +++ b/apps/user_ldap/user_ldap.php @@ -68,7 +68,7 @@ class USER_LDAP extends BackendUtility implements \OCP\IUserBackend, \OCP\UserIn * Check if the password is correct * @param string $uid The username * @param string $password The password - * @return boolean + * @return false|string * * Check if the password is correct without logging in the user */