Ensure that passed argument is always a string
Some code paths called the `normalizePath` functionality with types other than a string which resulted in unexpected behaviour. Thus the function is now manually casting the type to a string and I corrected the usage in list.php as well.
This commit is contained in:
parent
51f8d240c1
commit
9904b30070
|
@ -5,7 +5,7 @@ OCP\JSON::checkLoggedIn();
|
|||
$l = \OC::$server->getL10N('files');
|
||||
|
||||
// Load the files
|
||||
$dir = isset($_GET['dir']) ? $_GET['dir'] : '';
|
||||
$dir = isset($_GET['dir']) ? (string)$_GET['dir'] : '';
|
||||
$dir = \OC\Files\Filesystem::normalizePath($dir);
|
||||
|
||||
try {
|
||||
|
|
|
@ -723,9 +723,18 @@ class Filesystem {
|
|||
* Fix common problems with a file path
|
||||
* @param string $path
|
||||
* @param bool $stripTrailingSlash
|
||||
* @param bool $isAbsolutePath
|
||||
* @return string
|
||||
*/
|
||||
public static function normalizePath($path, $stripTrailingSlash = true, $isAbsolutePath = false) {
|
||||
/**
|
||||
* FIXME: This is a workaround for existing classes and files which call
|
||||
* this function with another type than a valid string. This
|
||||
* conversion should get removed as soon as all existing
|
||||
* function calls have been fixed.
|
||||
*/
|
||||
$path = (string)$path;
|
||||
|
||||
$cacheKey = json_encode([$path, $stripTrailingSlash, $isAbsolutePath]);
|
||||
|
||||
if(isset(self::$normalizedPathCache[$cacheKey])) {
|
||||
|
|
Loading…
Reference in New Issue