From 0c758dbe5b014715dd5adde625f5d3b4da3528cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 4 Sep 2018 22:21:22 +0200 Subject: [PATCH] Fix size of icons in menus inside apps when shown as images MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Some popover menus, like the contacts menu, still show their icon using an img element. The main CSS rules assume that a "content-box" sizing is being used, and thus set the size and padding of the image to add up to the line height. However, ".app-*" descendants use a "border-box" sizing, so when a menu with an image was shown in an app the icon was not properly shown. Now both the width and height of the image is set to the item height in those cases, which causes the visible size of the icon to be the item height minus the padding (the same as when "content-box" sizing is used). Signed-off-by: Daniel Calviño Sánchez --- core/css/apps.scss | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/core/css/apps.scss b/core/css/apps.scss index 3a56d72ecd..913e445f5b 100644 --- a/core/css/apps.scss +++ b/core/css/apps.scss @@ -1043,6 +1043,27 @@ $popovericon-size: 16px; } } +/* "app-*" descendants use border-box sizing, so the height of the icon must be + * set to the height of the item (as well as its width to make it squared). */ +#content[class*='app-'] { + .bubble, + .app-navigation-entry-menu, + .popovermenu { + li { + > button, + > a, + > .menuitem { + /* DEPRECATED! old img in popover fallback + * TODO: to remove */ + > img { + width: $popoveritem-height; + height: $popoveritem-height; + } + } + } + } +} + /* CONTENT LIST ------------------------------------------------------------ */ .app-content-list { width: 300px;