Merge pull request #23791 from nextcloud/fix/noid/psalm-update-baseline

Do not commit updated composer dependencies in psalm baseline update

.github/workflows/update-psalm-baseline.yml

@@ -26,7 +26,8 @@ jobs:
         run: composer run psalm -- --monochrome --no-progress --output-format=text --update-baseline
       - name: Reset composer.json and composer.lock
         run: |
-          git checkout -- composer.json composer.lock
+          rm -rf lib/composer
+          git checkout -- composer.json composer.lock lib/composer
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@v3
         with:

build/psalm-baseline.xml

@@ -1713,7 +1713,6 @@
   <file src="apps/files_sharing/lib/Controller/ShareController.php">
     <InvalidArgument occurrences="2">
       <code>$files_list</code>
-      <code>'Share is read-only'</code>
     </InvalidArgument>
     <InvalidScalarArgument occurrences="3">
       <code>$freeSpace</code>
@@ -2476,18 +2475,6 @@
       <code>Resource</code>
     </UndefinedDocblockClass>
   </file>
-  <file src="apps/user_ldap/lib/LDAPProviderFactory.php">
-    <ImplementedReturnTypeMismatch occurrences="1">
-      <code>OCP\LDAP\ILDAPProvider</code>
-    </ImplementedReturnTypeMismatch>
-    <InvalidReturnStatement occurrences="1"/>
-    <InvalidReturnType occurrences="1">
-      <code>OCP\LDAP\ILDAPProvider</code>
-    </InvalidReturnType>
-    <UndefinedDocblockClass occurrences="1">
-      <code>OCP\LDAP\ILDAPProvider</code>
-    </UndefinedDocblockClass>
-  </file>
   <file src="apps/user_ldap/lib/LogWrapper.php">
     <InvalidReturnType occurrences="1">
       <code>bool</code>
@@ -3213,11 +3200,6 @@
       <code>$default</code>
     </MoreSpecificImplementedParamType>
   </file>
-  <file src="lib/private/AppFramework/Services/InitialState.php">
-    <ImplementedParamTypeMismatch occurrences="1">
-      <code>$closure</code>
-    </ImplementedParamTypeMismatch>
-  </file>
   <file src="lib/private/Archive/TAR.php">
     <FalsableReturnStatement occurrences="1">
       <code>false</code>
@@ -3342,21 +3324,12 @@
     <ImplementedReturnTypeMismatch occurrences="1">
       <code>Color</code>
     </ImplementedReturnTypeMismatch>
-    <ImplicitToStringCast occurrences="1">
-      <code>$avatar</code>
-    </ImplicitToStringCast>
-    <InvalidNullableReturnType occurrences="1">
-      <code>string|boolean</code>
-    </InvalidNullableReturnType>
     <InvalidReturnStatement occurrences="1">
       <code>$finalPalette[$this-&gt;hashToInt($hash, $steps * 3)]</code>
     </InvalidReturnStatement>
     <InvalidReturnType occurrences="1">
       <code>Color</code>
     </InvalidReturnType>
-    <NullableReturnStatement occurrences="1">
-      <code>$image-&gt;data()</code>
-    </NullableReturnStatement>
   </file>
   <file src="lib/private/Avatar/GuestAvatar.php">
     <ImplementedReturnTypeMismatch occurrences="1">
@@ -5747,14 +5720,6 @@
       <code>$this-&gt;resources</code>
     </InvalidPropertyAssignmentValue>
   </file>
-  <file src="lib/public/AppFramework/Services/IInitialState.php">
-    <MismatchingDocblockParamType occurrences="1">
-      <code>Closure</code>
-    </MismatchingDocblockParamType>
-    <UndefinedDocblockClass occurrences="1">
-      <code>Closure</code>
-    </UndefinedDocblockClass>
-  </file>
   <file src="lib/public/BackgroundJob/TimedJob.php">
     <MoreSpecificImplementedParamType occurrences="1">
       <code>$jobList</code>