Merge pull request #15723 from owncloud/fix-decimal-unit-tests
Use data provider instead of hand-crafted for loops
This commit is contained in:
commit
9dee275033
|
@ -261,18 +261,14 @@ class Test_DB extends \Test\TestCase {
|
||||||
$this->assertSame($expected, $actual);
|
$this->assertSame($expected, $actual);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testDecimal() {
|
/**
|
||||||
|
* Insert, select and delete decimal(12,2) values
|
||||||
|
* @dataProvider decimalData
|
||||||
|
*/
|
||||||
|
public function testDecimal($insert, $expect) {
|
||||||
$table = "*PREFIX*" . $this->table4;
|
$table = "*PREFIX*" . $this->table4;
|
||||||
$rowname = 'decimaltest';
|
$rowname = 'decimaltest';
|
||||||
|
|
||||||
// Insert, select and delete decimal(12,2) values
|
|
||||||
$inserts = array('1337133713.37', '1234567890');
|
|
||||||
$expects = array('1337133713.37', '1234567890.00');
|
|
||||||
|
|
||||||
for ($i = 0; $i < count($inserts); $i++) {
|
|
||||||
$insert = $inserts[$i];
|
|
||||||
$expect = $expects[$i];
|
|
||||||
|
|
||||||
$query = OC_DB::prepare('INSERT INTO `' . $table . '` (`' . $rowname . '`) VALUES (?)');
|
$query = OC_DB::prepare('INSERT INTO `' . $table . '` (`' . $rowname . '`) VALUES (?)');
|
||||||
$result = $query->execute(array($insert));
|
$result = $query->execute(array($insert));
|
||||||
$this->assertEquals(1, $result);
|
$this->assertEquals(1, $result);
|
||||||
|
@ -286,6 +282,12 @@ class Test_DB extends \Test\TestCase {
|
||||||
$result = $query->execute();
|
$result = $query->execute();
|
||||||
$this->assertTrue((bool)$result);
|
$this->assertTrue((bool)$result);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public function decimalData() {
|
||||||
|
return [
|
||||||
|
['1337133713.37', '1337133713.37'],
|
||||||
|
['1234567890', '1234567890.00'],
|
||||||
|
];
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testUpdateAffectedRowsNoMatch() {
|
public function testUpdateAffectedRowsNoMatch() {
|
||||||
|
|
Loading…
Reference in New Issue