mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #19176 from nextcloud/fix/contacts-menu-mailt-encoding 

Do not encode contacts menu mailto links
This commit is contained in:
Roeland Jago Douma 2020-01-30 09:45:13 +01:00 committed by GitHub
parent 792c32aaa4 87ec729f34
commit 9ed106f69a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/private/Contacts/ContactsMenu/ActionFactory.php
View File

@ -50,7 +50,7 @@ class ActionFactory implements IActionFactory {
* @return ILinkAction * @return ILinkAction
*/ */
public function newEMailAction($icon, $name, $email) { public function newEMailAction($icon, $name, $email) {
return $this->newLinkAction($icon, $name, 'mailto:' . urlencode($email)); return $this->newLinkAction($icon, $name, 'mailto:' . $email);
} }
} }

2
tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
View File

@ -61,7 +61,7 @@ class ActionFactoryTest extends TestCase {
$this->assertInstanceOf(IAction::class, $action); $this->assertInstanceOf(IAction::class, $action);
$this->assertEquals($name, $action->getName()); $this->assertEquals($name, $action->getName());
$this->assertEquals(10, $action->getPriority()); $this->assertEquals(10, $action->getPriority());
$this->assertEquals('mailto:user%40example.com', $action->getHref()); $this->assertEquals('mailto:user@example.com', $action->getHref());
} }
} }