From 9fb37a2990b250d4416bb8cb7d00c477869a0fa5 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 19:25:32 +0200
Subject: [PATCH] Add proper labels to various form elements and buttons

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 apps/files/js/detailsview.js   |  2 +-
 apps/files/templates/list.php  |  4 +++-
 core/templates/layout.user.php | 10 ++++++----
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/apps/files/js/detailsview.js b/apps/files/js/detailsview.js
index e53922ebb6..a896e84fdc 100644
--- a/apps/files/js/detailsview.js
+++ b/apps/files/js/detailsview.js
@@ -23,7 +23,7 @@
 		'	{{/if}}' +
 		'	<div class="tabsContainer">' +
 		'	</div>' +
-		'	<a class="close icon-close" href="#" alt="{{closeLabel}}"></a>';
+		'	<a class="close icon-close" href="#"><span class="hidden-visually">{{closeLabel}}</span></a>';
 
 	/**
 	 * @class OCA.Files.DetailsView
diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php
index f3b6759644..46bd9351e3 100644
--- a/apps/files/templates/list.php
+++ b/apps/files/templates/list.php
@@ -4,7 +4,9 @@
 				<div id="uploadprogressbar">
 					<em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading @'));?></span><span class="mobile"><?php p($l->t('…'));?></span></em>
 				</div>
-				<input type="button" class="stop icon-close" style="display:none" value="" />
+				<button class="stop icon-close" style="display:none">
+					<span class="hidden-visually"><?php p($l->t('Cancel upload')) ?></span>
+				</button>
 			</div>
 		</div>
 		<div id="file_action_panel"></div>
diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 98cd8d6c28..16454b4f45 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -104,7 +104,7 @@
 					<input id="searchbox" type="search" name="query"
 						value="" required
 						autocomplete="off" tabindex="5">
-					<button class="icon-close-white" type="reset"></button>
+					<button class="icon-close-white" type="reset"><span class="hidden-visually"><?php p($l->t('Reset search'));?></span></button>
 				</form>
 				<div id="contactsmenu">
 					<div class="icon-contacts menutoggle"></div>
@@ -142,10 +142,12 @@
 
 		<div id="sudo-login-background" class="hidden"></div>
 		<form id="sudo-login-form" class="hidden">
-			<?php p($l->t('This action requires you to confirm your password:')); ?><br>
-			<input type="password" class="question" autocomplete="new-password" name="question" value=" <?php /* Hack against browsers ignoring autocomplete="off" */ ?>"
+			<label>
+				<?php p($l->t('This action requires you to confirm your password')); ?><br/>
+				<input type="password" class="question" autocomplete="new-password" name="question" value=" <?php /* Hack against browsers ignoring autocomplete="off" */ ?>"
 				placeholder="<?php p($l->t('Confirm your password')); ?>" />
-			<input class="confirm icon-confirm" title="<?php p($l->t('Confirm')); ?>" value="" type="submit">
+			</label>
+			<input class="confirm" value="<?php p($l->t('Confirm')); ?>" type="submit">
 		</form>
 
 		<div id="content-wrapper">