diff --git a/apps/theming/lib/ThemingDefaults.php b/apps/theming/lib/ThemingDefaults.php index 72286ece4b..fe1b1d4c17 100644 --- a/apps/theming/lib/ThemingDefaults.php +++ b/apps/theming/lib/ThemingDefaults.php @@ -151,9 +151,14 @@ class ThemingDefaults extends \OC_Defaults { public function getShortFooter() { $slogan = $this->getSlogan(); - $footer = '' .$this->getEntity() . ''. - ($slogan !== '' ? ' – ' . $slogan : ''); + $baseUrl = $this->getBaseUrl(); + if ($baseUrl !== '') { + $footer = '' . $this->getEntity() . ''; + } else { + $footer = '' .$this->getEntity() . ''; + } + $footer .= ($slogan !== '' ? ' – ' . $slogan : ''); $links = [ [ diff --git a/apps/theming/tests/ThemingDefaultsTest.php b/apps/theming/tests/ThemingDefaultsTest.php index 87b2003ded..5d075709dc 100644 --- a/apps/theming/tests/ThemingDefaultsTest.php +++ b/apps/theming/tests/ThemingDefaultsTest.php @@ -262,7 +262,22 @@ class ThemingDefaultsTest extends TestCase { ['theming', 'privacyUrl', '', ''], ]); - $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); + $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); + } + + public function testGetShortFooterEmptyUrl() { + $this->config + ->expects($this->exactly(5)) + ->method('getAppValue') + ->willReturnMap([ + ['theming', 'url', $this->defaults->getBaseUrl(), ''], + ['theming', 'name', 'Nextcloud', 'Name'], + ['theming', 'slogan', $this->defaults->getSlogan(), 'Slogan'], + ['theming', 'imprintUrl', '', ''], + ['theming', 'privacyUrl', '', ''], + ]); + + $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); } public function testGetShortFooterEmptySlogan() { @@ -277,7 +292,7 @@ class ThemingDefaultsTest extends TestCase { ['theming', 'privacyUrl', '', ''], ]); - $this->assertEquals('Name', $this->template->getShortFooter()); + $this->assertEquals('Name', $this->template->getShortFooter()); } public function testGetShortFooterImprint() { @@ -297,7 +312,7 @@ class ThemingDefaultsTest extends TestCase { ->method('t') ->willReturnArgument(0); - $this->assertEquals('Name – Slogan
Legal notice', $this->template->getShortFooter()); + $this->assertEquals('Name – Slogan
Legal notice', $this->template->getShortFooter()); } public function testGetShortFooterPrivacy() { @@ -317,7 +332,7 @@ class ThemingDefaultsTest extends TestCase { ->method('t') ->willReturnArgument(0); - $this->assertEquals('Name – Slogan
Privacy policy', $this->template->getShortFooter()); + $this->assertEquals('Name – Slogan
Privacy policy', $this->template->getShortFooter()); } public function testGetShortFooterAllLegalLinks() { @@ -337,7 +352,7 @@ class ThemingDefaultsTest extends TestCase { ->method('t') ->willReturnArgument(0); - $this->assertEquals('Name – Slogan
Legal notice · Privacy policy', $this->template->getShortFooter()); + $this->assertEquals('Name – Slogan
Legal notice · Privacy policy', $this->template->getShortFooter()); } public function invalidLegalUrlProvider() { @@ -363,7 +378,7 @@ class ThemingDefaultsTest extends TestCase { ['theming', 'privacyUrl', '', ''], ]); - $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); + $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); } /** @@ -382,7 +397,7 @@ class ThemingDefaultsTest extends TestCase { ['theming', 'privacyUrl', '', $invalidPrivacyUrl], ]); - $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); + $this->assertEquals('Name – Slogan', $this->template->getShortFooter()); } public function testgetColorPrimaryWithDefault() { diff --git a/core/css/guest.css b/core/css/guest.css index 5f4eaefe80..fc926688c4 100644 --- a/core/css/guest.css +++ b/core/css/guest.css @@ -746,7 +746,7 @@ footer { margin-top: auto; } -footer .info a { +footer .info .entity-name { font-weight: 600; }