From a226f65aa228652a7f0a35676055ce3f4323fdf8 Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Fri, 26 Oct 2018 17:31:42 +0200 Subject: [PATCH] Fix off-by-one bugs This fixes warnings from LGTM: Off-by-one index comparison against length may lead to out-of-bounds read. Signed-off-by: Stefan Weil --- apps/user_ldap/js/wizard/wizard.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/user_ldap/js/wizard/wizard.js b/apps/user_ldap/js/wizard/wizard.js index 62a3fccbdf..9ac03e117c 100644 --- a/apps/user_ldap/js/wizard/wizard.js +++ b/apps/user_ldap/js/wizard/wizard.js @@ -45,7 +45,7 @@ OCA = OCA || {}; // for example, BaseDN detector needs the port. The port is typically found // by the Port Detector. If BaseDN detector was run first, it will not have // all necessary information. Only after Port Detector was executed… - for (var i = 0; i <= detectors.length; i++) { + for (var i = 0; i < detectors.length; i++) { model.registerDetector(detectors[i]); } @@ -61,7 +61,7 @@ OCA = OCA || {}; var view = new OCA.LDAP.Wizard.WizardView(model); view.init(); view.setModel(model); - for (var j = 0; j <= tabs.length; j++) { + for (var j = 0; j < tabs.length; j++) { view.registerTab(tabs[j], '#ldapWizard' + (j + 2)); }