add loading feedback to user menu entries (#23916)

fixes #19857

core/css/header.css

@@ -294,6 +294,12 @@
 	color: #bbb;
 	cursor: pointer;
 }
+#settings .icon-loading-dark {
+	display: inline-block;
+	margin-bottom: -3px;
+	margin-right: 6px;
+	background-size: 16px 16px;
+}
 #expand {
 	display: block;
 	padding: 7px 30px 6px 10px;

core/js/js.js

@@ -1557,7 +1557,22 @@ function initCore() {
 		});
 	}
 
+	function setupUserMenu() {
+		var $menu = $('#header #settings');
+
+		$menu.delegate('a', 'click', function(event) {
+			var $page = $(event.target);
+			if (!$page.is('a')) {
+				$page = $page.closest('a');
+			}
+			$page.find('img').remove();
+			$page.find('div').remove(); // prevent odd double-clicks
+			$page.prepend($('<div/>').addClass('icon-loading-dark'));
+		});
+	}
+
 	setupMainMenu();
+	setupUserMenu();
 
 	// move triangle of apps dropdown to align with app name triangle
 	// 2 is the additional offset between the triangles