From a35b0956f1eb741a1c16d9408048623cb9bc3c02 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julius=20H=C3=A4rtl?= <jus@bitgrid.net>
Date: Tue, 3 Nov 2020 17:24:06 +0100
Subject: [PATCH] Add github action for oci8
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Julius Härtl <jus@bitgrid.net>
---
 .github/workflows/oci.yml   | 53 +++++++++++++++++++++++++++++++++++++
 tests/lib/AppConfigTest.php |  5 ++--
 tests/lib/DB/testschema.xml |  2 +-
 3 files changed, 57 insertions(+), 3 deletions(-)
 create mode 100644 .github/workflows/oci.yml

diff --git a/.github/workflows/oci.yml b/.github/workflows/oci.yml
new file mode 100644
index 0000000000..87cc1d41d4
--- /dev/null
+++ b/.github/workflows/oci.yml
@@ -0,0 +1,53 @@
+name: "Unit tests"
+
+on:
+  push:
+
+jobs:
+  phpunit-oci8:
+    name: "PHPUnit on OCI8"
+    runs-on: "ubuntu-latest"
+
+    strategy:
+      matrix:
+        php-version:
+          - "7.4"
+
+    services:
+      oracle:
+        image: deepdiver/docker-oracle-xe-11g # "wnameless/oracle-xe-11g-r2"
+        ports:
+          - "1521:1521"
+
+    steps:
+      - name: "Checkout"
+        uses: "actions/checkout@v2"
+
+      - name: Checkout submodules
+        shell: bash
+        run: |
+          auth_header="$(git config --local --get http.https://github.com/.extraheader)"
+          git submodule sync --recursive
+          git -c "http.extraheader=$auth_header" -c protocol.version=2 submodule update --init --force --recursive --depth=1
+
+      - name: "Install PHP"
+        uses: "shivammathur/setup-php@v2"
+        with:
+          php-version: "${{ matrix.php-version }}"
+          extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite, oci8
+          tools: phpunit:8.5.2
+          coverage: none
+
+      - name: Set up Nextcloud
+        run: |
+          mkdir data
+          ./occ maintenance:install --verbose --database=oci --database-name=XE --database-host=127.0.0.1 --database-port=1521 --database-user=autotest --database-pass=owncloud --admin-user admin --admin-pass admin
+
+      # Generate instance id by loading index.php
+      - name: Generate instance id by loading index.php
+        run: |
+          php -f index.php
+
+      - name: Run phpunit
+        run: |
+          cd tests && phpunit --configuration phpunit-autotest.xml --group DB,SLOWDB
diff --git a/tests/lib/AppConfigTest.php b/tests/lib/AppConfigTest.php
index ff23454eb8..40a99709bd 100644
--- a/tests/lib/AppConfigTest.php
+++ b/tests/lib/AppConfigTest.php
@@ -9,6 +9,7 @@
 
 namespace Test;
 
+use OC\AppConfig;
 use OCP\IConfig;
 
 /**
@@ -42,7 +43,7 @@ class AppConfigTest extends TestCase {
 		$sql->delete('appconfig');
 		$sql->execute();
 
-		$this->overwriteService('AppConfig', new \OC\AppConfig($this->connection));
+		$this->overwriteService(AppConfig::class, new \OC\AppConfig($this->connection));
 
 		$sql = $this->connection->getQueryBuilder();
 		$sql->insert('appconfig')
@@ -132,7 +133,7 @@ class AppConfigTest extends TestCase {
 			$sql->execute();
 		}
 
-		$this->restoreService('AppConfig');
+		$this->restoreService(AppConfig::class);
 		parent::tearDown();
 	}
 
diff --git a/tests/lib/DB/testschema.xml b/tests/lib/DB/testschema.xml
index 5f449c936d..d42dbe8d58 100644
--- a/tests/lib/DB/testschema.xml
+++ b/tests/lib/DB/testschema.xml
@@ -37,7 +37,7 @@
 			</field>
 			<field>
 				<name>clobfield</name>
-				<type>clob</type>
+				<type>text</type>
 			</field>
 			<field>
 				<name>booleanfield</name>