From a35bebd7d4e64c70924ded052466fe42e79a6545 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Fri, 5 Feb 2021 08:45:58 +0100 Subject: [PATCH] Log deprecation notice of GenericEventWrapper just once Signed-off-by: Christoph Wurst --- lib/private/EventDispatcher/GenericEventWrapper.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/private/EventDispatcher/GenericEventWrapper.php b/lib/private/EventDispatcher/GenericEventWrapper.php index 916297f499..1935c67581 100644 --- a/lib/private/EventDispatcher/GenericEventWrapper.php +++ b/lib/private/EventDispatcher/GenericEventWrapper.php @@ -41,6 +41,9 @@ class GenericEventWrapper extends GenericEvent { /** @var string */ private $eventName; + /** @var bool */ + private $deprecationNoticeLogged = false; + public function __construct(ILogger $logger, string $eventName, ?GenericEvent $event) { parent::__construct($eventName); $this->logger = $logger; @@ -49,11 +52,16 @@ class GenericEventWrapper extends GenericEvent { } private function log() { + if ($this->deprecationNoticeLogged) { + return; + } + $class = ($this->event !== null && is_object($this->event)) ? get_class($this->event) : 'null'; $this->logger->info( 'Deprecated event type for {name}: {class} is used', [ 'name' => $this->eventName, 'class' => $class] ); + $this->deprecationNoticeLogged = true; } public function isPropagationStopped(): bool {