From a3cbdcf202ee1b28fb3109c91e4d32194bdeebb6 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Sun, 3 Jan 2016 16:53:44 +0100 Subject: [PATCH] Faster AppConfig->getValues --- lib/private/appconfig.php | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lib/private/appconfig.php b/lib/private/appconfig.php index d1c1e4bfc4..17e474bd77 100644 --- a/lib/private/appconfig.php +++ b/lib/private/appconfig.php @@ -251,14 +251,13 @@ class AppConfig implements IAppConfig { if ($key === false) { return $this->getAppValues($app); } else { - $configs = []; - foreach ($this->getApps() as $appId) { - if ($this->hasKey($appId, $key)) { - $configs[$appId] = $this->getValue($appId, $key); - } - } + $appIds = $this->getApps(); + $values = array_map(function($appId) use ($key) { + return isset($this->cache[$appId][$key]) ? $this->cache[$appId][$key] : null; + }, $appIds); + $result = array_combine($appIds, $values); - return $configs; + return array_filter($result); } }