From ab036d47645867374cb6f4f2d168f407e96ceda5 Mon Sep 17 00:00:00 2001 From: Bjoern Schiessle Date: Mon, 2 Jul 2012 17:52:51 +0200 Subject: [PATCH] webdav client crashes for secure connections if he doesn't have the right root certificate for ssl verification. For the moment I print at least a useful error message to the OC log and the Apache log --- 3rdparty/Sabre/DAV/Client.php | 1 + apps/files_external/lib/webdav.php | 2 ++ 2 files changed, 3 insertions(+) diff --git a/3rdparty/Sabre/DAV/Client.php b/3rdparty/Sabre/DAV/Client.php index a8320dd978..23bd7c0539 100644 --- a/3rdparty/Sabre/DAV/Client.php +++ b/3rdparty/Sabre/DAV/Client.php @@ -249,6 +249,7 @@ class Sabre_DAV_Client { // Automatically follow redirects CURLOPT_FOLLOWLOCATION => true, CURLOPT_MAXREDIRS => 5, + //CURLOPT_SSL_VERIFYPEER => false, ); switch ($method) { diff --git a/apps/files_external/lib/webdav.php b/apps/files_external/lib/webdav.php index d0fe2aca85..dda8afe9f2 100644 --- a/apps/files_external/lib/webdav.php +++ b/apps/files_external/lib/webdav.php @@ -96,6 +96,8 @@ class OC_FileStorage_DAV extends OC_Filestorage_Common{ $responseType=$response["{DAV:}resourcetype"]->resourceType; return (count($responseType)>0 and $responseType[0]=="{DAV:}collection")?'dir':'file'; }catch(Exception $e){ + error_log($e->getMessage()); + \OCP\Util::writeLog("webdav client", \OCP\Util::sanitizeHTML($e->getMessage()), \OCP\Util::ERROR); return false; } }