From ac27163f686ea082c3ca565a26c1c76db0728237 Mon Sep 17 00:00:00 2001 From: Robin McCorkell Date: Thu, 31 Mar 2016 23:20:00 +0100 Subject: [PATCH] Move Dropbox/GDrive link to icon --- apps/files_external/css/settings.css | 5 +++++ apps/files_external/js/dropbox.js | 10 ++++++---- apps/files_external/js/gdrive.js | 10 ++++++---- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/apps/files_external/css/settings.css b/apps/files_external/css/settings.css index d6df4fa074..6dfb012b15 100644 --- a/apps/files_external/css/settings.css +++ b/apps/files_external/css/settings.css @@ -18,6 +18,11 @@ td.mountPoint, td.backend { width:160px; } #addMountPoint>td.applicable { visibility:hidden; } #addMountPoint>td.hidden { visibility:hidden; } +#externalStorage .icon-settings { + padding: 11px 20px; + vertical-align: text-bottom; +} + #selectBackend { margin-left: -10px; width: 150px; diff --git a/apps/files_external/js/dropbox.js b/apps/files_external/js/dropbox.js index 9e1427e460..8302f5711d 100644 --- a/apps/files_external/js/dropbox.js +++ b/apps/files_external/js/dropbox.js @@ -11,17 +11,19 @@ $(document).ready(function() { OCA.External.Settings.mountConfig.whenSelectBackend(function($tr, backend, onCompletion) { if (backend === 'dropbox') { - var config = $tr.find('.configuration'); + var backendEl = $tr.find('.backend'); var el = $(document.createElement('a')) .attr('href', generateUrl($tr)) .attr('target', '_blank') - .text(t('files_external', 'Dropbox Configuration') + ' ↗') + .attr('title', t('files_external', 'Dropbox App Configuration')) + .addClass('icon-settings svg') ; el.on('click', function(event) { var a = $(event.target); - a.attr('href', generateUrl($(this).parent())); + a.attr('href', generateUrl($(this).closest('tr'))); }); - config.append(el); + el.tooltip({placement: 'top'}); + backendEl.append(el); } }); diff --git a/apps/files_external/js/gdrive.js b/apps/files_external/js/gdrive.js index e660aa8cb2..e02cedd6b4 100644 --- a/apps/files_external/js/gdrive.js +++ b/apps/files_external/js/gdrive.js @@ -7,17 +7,19 @@ $(document).ready(function() { OCA.External.Settings.mountConfig.whenSelectBackend(function($tr, backend, onCompletion) { if (backend === 'googledrive') { - var config = $tr.find('.configuration'); + var backendEl = $tr.find('.backend'); var el = $(document.createElement('a')) .attr('href', generateUrl($tr)) .attr('target', '_blank') - .text(t('files_external', 'Google Drive Configuration') + ' ↗') + .attr('title', t('files_external', 'Google Drive App Configuration')) + .addClass('icon-settings svg') ; el.on('click', function(event) { var a = $(event.target); - a.attr('href', generateUrl($(this).parent())); + a.attr('href', generateUrl($(this).closest('tr'))); }); - config.append(el); + el.tooltip({placement: 'top'}); + backendEl.append(el); } });