From ace96a406a4fea0dcc07abd003495da34b5fa71c Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Mon, 4 Dec 2017 22:49:01 +0100 Subject: [PATCH] Show hint that PHP 5.6 will not be supported in Nextcloud 14 anymore Signed-off-by: Morris Jobke --- core/js/setupchecks.js | 6 ++++++ settings/Controller/CheckSetupController.php | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/core/js/setupchecks.js b/core/js/setupchecks.js index c952c0a9a4..44bf33dd71 100644 --- a/core/js/setupchecks.js +++ b/core/js/setupchecks.js @@ -122,6 +122,12 @@ type: OC.SetupChecks.MESSAGE_TYPE_INFO }); } + if(data.phpSupported && data.phpSupported.version.substr(0, 3) === '5.6') { + messages.push({ + msg: t('core', 'You are currently running PHP 5.6. The current major version of Nextcloud is the last that is supported on PHP 5.6. It is recommended to upgrade the PHP version to 7.0+ to be able to upgrade to Nextcloud 14.'), + type: OC.SetupChecks.MESSAGE_TYPE_INFO + }); + } if(!data.forwardedForHeadersWorking) { messages.push({ msg: t('core', 'The reverse proxy header configuration is incorrect, or you are accessing Nextcloud from a trusted proxy. If not, this is a security issue and can allow an attacker to spoof their IP address as visible to the Nextcloud. Further information can be found in the documentation.', {docLink: data.reverseProxyDocs}), diff --git a/settings/Controller/CheckSetupController.php b/settings/Controller/CheckSetupController.php index ccaaaeaf60..5b7953bf39 100644 --- a/settings/Controller/CheckSetupController.php +++ b/settings/Controller/CheckSetupController.php @@ -238,7 +238,7 @@ class CheckSetupController extends Controller { * @return bool */ protected function isPhpOutdated() { - if (version_compare(PHP_VERSION, '5.5.0') === -1) { + if (version_compare(PHP_VERSION, '7.0.0', '<')) { return true; }