Remove tests that just prove mocked calls and don't actually validate anything useful

Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl 2021-04-01 16:19:16 +02:00
parent 0ab2383485
commit aebf574056
No known key found for this signature in database
GPG Key ID: 4C614C6ED2CDE6DF
1 changed files with 0 additions and 91 deletions

View File

@ -21,102 +21,11 @@
namespace Test\Security; namespace Test\Security;
use OC\DB\ConnectionAdapter;
use OC\Security\CredentialsManager;
use OC\SystemConfig;
use OCP\IDBConnection;
use OCP\ILogger;
use OCP\Security\ICrypto;
/** /**
* @group DB * @group DB
*/ */
class CredentialsManagerTest extends \Test\TestCase { class CredentialsManagerTest extends \Test\TestCase {
/** @var ICrypto */
protected $crypto;
/** @var IDBConnection */
protected $dbConnection;
/** @var ConnectionAdapter */
protected $dbConnectionAdapter;
/** @var CredentialsManager */
protected $manager;
protected function setUp(): void {
parent::setUp();
$this->crypto = $this->createMock(ICrypto::class);
$this->dbConnection = $this->getMockBuilder(IDBConnection::class)
->disableOriginalConstructor()
->getMock();
$this->dbConnectionAdapter = $this->getMockBuilder(ConnectionAdapter::class)
->disableOriginalConstructor()
->getMock();
$this->manager = new CredentialsManager($this->crypto, $this->dbConnection);
}
private function getQueryResult($row) {
$result = $this->getMockBuilder('\Doctrine\DBAL\Driver\Statement')
->disableOriginalConstructor()
->getMock();
$result->expects($this->any())
->method('fetch')
->willReturn($row);
return $result;
}
public function testStore() {
$userId = 'abc';
$identifier = 'foo';
$credentials = 'bar';
$this->crypto->expects($this->once())
->method('encrypt')
->with(json_encode($credentials))
->willReturn('baz');
$this->dbConnection->expects($this->once())
->method('setValues')
->with(CredentialsManager::DB_TABLE,
['user' => $userId, 'identifier' => $identifier],
['credentials' => 'baz']
);
$this->manager->store($userId, $identifier, $credentials);
}
public function testRetrieve() {
$userId = 'abc';
$identifier = 'foo';
$this->crypto->expects($this->once())
->method('decrypt')
->with('baz')
->willReturn(json_encode('bar'));
$qb = $this->getMockBuilder(\OC\DB\QueryBuilder\QueryBuilder::class)
->setConstructorArgs([
$this->dbConnectionAdapter,
$this->createMock(SystemConfig::class),
$this->createMock(ILogger::class),
])
->setMethods(['execute'])
->getMock();
$qb->expects($this->once())
->method('execute')
->willReturn($this->getQueryResult(['credentials' => 'baz']));
$this->dbConnectionAdapter->expects($this->once())
->method('getQueryBuilder')
->willReturn($qb);
$this->manager->retrieve($userId, $identifier);
}
/** /**
* @dataProvider credentialsProvider * @dataProvider credentialsProvider
*/ */