From b19fae262994a847fa6f74fe629140ba11daca80 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Tue, 12 Dec 2017 14:33:30 +0100 Subject: [PATCH] Fix error log on PHP 7.2 Fixes following error in the logs: "ini_set(): A session is active. You cannot change the session module's ini settings at this time" Signed-off-by: Morris Jobke --- lib/base.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/base.php b/lib/base.php index f6b4f5555e..d0672785ce 100644 --- a/lib/base.php +++ b/lib/base.php @@ -412,6 +412,10 @@ class OC { } public static function initSession() { + if(self::$server->getRequest()->getServerProtocol() === 'https') { + ini_set('session.cookie_secure', true); + } + // prevents javascript from accessing php session cookies ini_set('session.cookie_httponly', true); @@ -663,9 +667,6 @@ class OC { self::checkInstalled(); OC_Response::addSecurityHeaders(); - if(self::$server->getRequest()->getServerProtocol() === 'https') { - ini_set('session.cookie_secure', true); - } self::performSameSiteCookieProtection();