mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use formal type hints instead of informal PHPDoc 

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
Morris Jobke 2020-07-06 10:13:23 +02:00
parent 9b10d35477
commit b1cdd0dd9b
No known key found for this signature in database
GPG Key ID: FE03C3A163FEDE68
2 changed files with 9 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
lib/private/BackgroundJob/Job.php
View File

@ -32,26 +32,16 @@ use OCP\BackgroundJob\IJobList;
use OCP\ILogger; use OCP\ILogger;
abstract class Job implements IJob { abstract class Job implements IJob {
/** /** @var int */
* @var int $id
*/
protected $id; protected $id;
/** /** @var int */
* @var int $lastRun
*/
protected $lastRun; protected $lastRun;
/** /** @var mixed */
* @var mixed $argument
*/
protected $argument; protected $argument;
/** public function execute(IJobList $jobList, ILogger $logger = null) {
* @param IJobList $jobList
* @param ILogger|null $logger
*/
public function execute($jobList, ILogger $logger = null) {
$jobList->setLastRun($this); $jobList->setLastRun($this);
if ($logger === null) { if ($logger === null) {
$logger = \OC::$server->getLogger(); $logger = \OC::$server->getLogger();
@ -77,11 +67,11 @@ abstract class Job implements IJob {
abstract protected function run($argument); abstract protected function run($argument);
public function setId($id) { public function setId(int $id) {
$this->id = $id; $this->id = $id;
} }
public function setLastRun($lastRun) { public function setLastRun(int $lastRun) {
$this->lastRun = $lastRun; $this->lastRun = $lastRun;
} }

8
lib/public/BackgroundJob/IJob.php
View File

@ -42,19 +42,17 @@ interface IJob {
* @param ILogger|null $logger * @param ILogger|null $logger
* @since 7.0.0 * @since 7.0.0
*/ */
public function execute($jobList, ILogger $logger = null); public function execute(IJobList $jobList, ILogger $logger = null);
/** /**
* @param int $id
* @since 7.0.0 * @since 7.0.0
*/ */
public function setId($id); public function setId(int $id);
/** /**
* @param int $lastRun
* @since 7.0.0 * @since 7.0.0
*/ */
public function setLastRun($lastRun); public function setLastRun(int $lastRun);
/** /**
* @param mixed $argument * @param mixed $argument