From 8cef51bbada45f8b5b862f46973ffc2b2d549f8d Mon Sep 17 00:00:00 2001 From: Thomas Citharel Date: Thu, 4 Jun 2020 11:08:20 +0200 Subject: [PATCH] Fix empty event UUID reminder notifications Signed-off-by: Thomas Citharel --- .../CalDAV/Reminder/NotificationProvider/PushProvider.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php b/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php index c6b796b2ac..688e5c3b10 100644 --- a/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php +++ b/apps/dav/lib/CalDAV/Reminder/NotificationProvider/PushProvider.php @@ -95,8 +95,10 @@ class PushProvider extends AbstractProvider { $eventDetails = $this->extractEventDetails($vevent); $eventDetails['calendar_displayname'] = $calendarDisplayName; $eventUUID = (string) $vevent->UID; - // Empty Notification ObjectId will be catched by OC\Notification\Notification - $eventUUIDHash = $eventUUID ? hash('sha256', $eventUUID, false) : ''; + if (!$eventUUID) { + return; + }; + $eventUUIDHash = hash('sha256', $eventUUID, false); foreach ($users as $user) { /** @var INotification $notification */