From dc5fea504b195cf1e36f9a129d1f77ce7c91de13 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Sun, 3 Jul 2016 16:54:41 +0200 Subject: [PATCH 1/3] [master] Use paramterized parameter for \OC\SystemTag\SystemTagManager $nameSearchPattern was passed in and directly appended to the SQL query. Luckily the code path isn't reached anywhere in Nextcloud or the included apps. --- lib/private/SystemTag/SystemTagManager.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/private/SystemTag/SystemTagManager.php b/lib/private/SystemTag/SystemTagManager.php index 2b0ef03e47..3e32582025 100644 --- a/lib/private/SystemTag/SystemTagManager.php +++ b/lib/private/SystemTag/SystemTagManager.php @@ -140,10 +140,7 @@ class SystemTagManager implements ISystemTagManager { if (!empty($nameSearchPattern)) { $query->andWhere( - $query->expr()->like( - 'name', - $query->expr()->literal('%' . $this->connection->escapeLikeParameter($nameSearchPattern). '%') - ) + $query->expr()->like('name', $query->createNamedParameter('%' . $this->connection->escapeLikeParameter($nameSearchPattern) . '%')) ); } From 8e0e7937f5d93fa93cfaab794a50c09f711ceeb1 Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 4 Jul 2016 10:40:13 +0200 Subject: [PATCH 2/3] Collapse logs and lists with HTML5 support of github --- issue_template.md | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/issue_template.md b/issue_template.md index a17628377b..94aad9a5b0 100644 --- a/issue_template.md +++ b/issue_template.md @@ -34,22 +34,30 @@ Tell us what happens instead **Where did you install Nextcloud from:** **Signing status (Nextcloud 9.0 and above):** +
+Signing status ``` Login as admin user into your Nextcloud and access http://example.com/index.php/settings/integrity/failed paste the results here. ``` +
**List of activated apps:** +
+App list ``` If you have access to your command line run e.g.: sudo -u www-data php occ app:list from within your Nextcloud installation folder ``` +
**The content of config/config.php:** +
+Config report ``` If you have access to your command line run e.g.: @@ -61,6 +69,7 @@ or Insert your config.php content here (Without the database password, passwordsalt and secret) ``` +
**Are you using external storage, if yes which one:** local/smb/sftp/... @@ -69,6 +78,8 @@ Insert your config.php content here **Are you using an external user-backend, if yes which one:** LDAP/ActiveDirectory/Webdav/... #### LDAP configuration (delete this part if not used) +
+LDAP config ``` With access to your command line run e.g.: @@ -82,6 +93,7 @@ SELECT * FROM `oc_appconfig` WHERE `appid` = 'user_ldap'; Eventually replace sensitive data as the name/IP-address of your LDAP server or groups. ``` +
### Client configuration **Browser:** @@ -90,20 +102,29 @@ Eventually replace sensitive data as the name/IP-address of your LDAP server or ### Logs #### Web server error log +
+Browser log ``` Insert your webserver log here ``` +
#### Nextcloud log (data/owncloud.log) +
+Browser log ``` Insert your Nextcloud log here ``` +
#### Browser log +
+Browser log ``` Insert your browser log here, this could for example include: a) The javascript console log -b) The network log +b) The network log c) ... ``` +
From 55ad79a97f0079060df909bc64e81635fea90d18 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Mon, 4 Jul 2016 11:56:38 +0200 Subject: [PATCH 3/3] Fix summary --- issue_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/issue_template.md b/issue_template.md index 94aad9a5b0..f7906700c9 100644 --- a/issue_template.md +++ b/issue_template.md @@ -103,7 +103,7 @@ Eventually replace sensitive data as the name/IP-address of your LDAP server or ### Logs #### Web server error log
-Browser log +Web server error log ``` Insert your webserver log here ``` @@ -111,7 +111,7 @@ Insert your webserver log here #### Nextcloud log (data/owncloud.log)
-Browser log +Nextcloud log ``` Insert your Nextcloud log here ```