mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Test for proper removal of mount entries 

Signed-off-by: Julius Härtl <jus@bitgrid.net>
This commit is contained in:
Julius Härtl 2020-07-08 09:54:26 +02:00
parent 479aa975d3
commit c06e69c9dd
No known key found for this signature in database
GPG Key ID: 4C614C6ED2CDE6DF
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
apps/files/tests/Command/DeleteOrphanedFilesTest.php
View File

@ -87,6 +87,11 @@ class DeleteOrphanedFilesTest extends TestCase {
return $stmt->fetchAll(); return $stmt->fetchAll();
} }
protected function getMounts($storageId) {
$stmt = $this->connection->executeQuery('SELECT * FROM `*PREFIX*mounts` WHERE `storage_id` = ?', [$storageId]);
return $stmt->fetchAll();
}
/** /**
* Test clearing orphaned files * Test clearing orphaned files
*/ */
@ -98,20 +103,28 @@ class DeleteOrphanedFilesTest extends TestCase {
->disableOriginalConstructor() ->disableOriginalConstructor()
->getMock(); ->getMock();
// scan home storage so that mounts are properly setup
\OC::$server->getRootFolder()->getUserFolder($this->user1)->getStorage()->getScanner()->scan('');
$this->loginAsUser($this->user1); $this->loginAsUser($this->user1);
$view = new View('/' . $this->user1 . '/'); $view = new View('/' . $this->user1 . '/');
$view->mkdir('files/test'); $view->mkdir('files/test');
$fileInfo = $view->getFileInfo('files/test'); $fileInfo = $view->getFileInfo('files/test');
$storageId = $fileInfo->getStorage()->getId(); $storageId = $fileInfo->getStorage()->getId();
$numericStorageId = $fileInfo->getStorage()->getStorageCache()->getNumericId();
$this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is available'); $this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is available');
$this->assertCount(1, $this->getMounts($numericStorageId), 'Asserts that mount is available');
$this->command->execute($input, $output); $this->command->execute($input, $output);
$this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is still available'); $this->assertCount(1, $this->getFile($fileInfo->getId()), 'Asserts that file is still available');
$this->assertCount(1, $this->getMounts($numericStorageId), 'Asserts that mount is still available');
$deletedRows = $this->connection->executeUpdate('DELETE FROM `*PREFIX*storages` WHERE `id` = ?', [$storageId]); $deletedRows = $this->connection->executeUpdate('DELETE FROM `*PREFIX*storages` WHERE `id` = ?', [$storageId]);
$this->assertNotNull($deletedRows, 'Asserts that storage got deleted'); $this->assertNotNull($deletedRows, 'Asserts that storage got deleted');
@ -119,13 +132,19 @@ class DeleteOrphanedFilesTest extends TestCase {
// parent folder, `files`, ´test` and `welcome.txt` => 4 elements // parent folder, `files`, ´test` and `welcome.txt` => 4 elements
$output $output
->expects($this->once()) ->expects($this->at(0))
->method('writeln') ->method('writeln')
->with('3 orphaned file cache entries deleted'); ->with('3 orphaned file cache entries deleted');
$output
->expects($this->at(1))
->method('writeln')
->with('1 orphaned mount entries deleted');
$this->command->execute($input, $output); $this->command->execute($input, $output);
$this->assertCount(0, $this->getFile($fileInfo->getId()), 'Asserts that file gets cleaned up'); $this->assertCount(0, $this->getFile($fileInfo->getId()), 'Asserts that file gets cleaned up');
$this->assertCount(0, $this->getMounts($numericStorageId), 'Asserts that mount gets cleaned up');
// since we deleted the storage it might throw a (valid) StorageNotAvailableException // since we deleted the storage it might throw a (valid) StorageNotAvailableException
try { try {