Prefetching blows up if there are a lot of files.
I saw instances where people had a lot of files (each with custom properties) and all this prefetching blew up and started to consume an insane amount of RAM resulting in the process getting killed. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
parent
f5d0f746f9
commit
c16d116fa6
|
@ -129,13 +129,6 @@ class CustomPropertiesBackend implements BackendInterface {
|
|||
return;
|
||||
}
|
||||
|
||||
if ($node instanceof Directory
|
||||
&& $propFind->getDepth() !== 0
|
||||
) {
|
||||
// note: pre-fetching only supported for depth <= 1
|
||||
$this->loadChildrenProperties($node, $requestedProps);
|
||||
}
|
||||
|
||||
$props = $this->getProperties($node, $requestedProps);
|
||||
foreach ($props as $propName => $propValue) {
|
||||
$propFind->set($propName, $propValue);
|
||||
|
|
|
@ -226,10 +226,6 @@ class CustomPropertiesBackendTest extends \Test\TestCase {
|
|||
->method('getPath')
|
||||
->will($this->returnValue('/dummypath/test.txt'));
|
||||
|
||||
$rootNode->expects($this->once())
|
||||
->method('getChildren')
|
||||
->will($this->returnValue(array($nodeSub)));
|
||||
|
||||
$this->tree->expects($this->at(0))
|
||||
->method('getNodeForPath')
|
||||
->with('/dummypath')
|
||||
|
|
Loading…
Reference in New Issue