add additional comments, PHPdoc and check whether it's really applicable
This commit is contained in:
parent
1c71d5c444
commit
c1c2f2c49e
|
@ -434,16 +434,25 @@ class Access extends LDAPUtility {
|
||||||
$ocname = $this->dn2ocname($ldapObject['dn'], $nameByLDAP, $isUsers);
|
$ocname = $this->dn2ocname($ldapObject['dn'], $nameByLDAP, $isUsers);
|
||||||
if($ocname) {
|
if($ocname) {
|
||||||
$ownCloudNames[] = $ocname;
|
$ownCloudNames[] = $ocname;
|
||||||
$this->cacheDisplayName($ocname, $nameByLDAP);
|
if($isUsers) {
|
||||||
|
//cache the user names so it does not need to be retrieved
|
||||||
|
//again later (e.g. sharing dialogue).
|
||||||
|
$this->cacheUserDisplayName($ocname, $nameByLDAP);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
return $ownCloudNames;
|
return $ownCloudNames;
|
||||||
}
|
}
|
||||||
|
|
||||||
public function cacheDisplayName($uid, $displayName) {
|
/**
|
||||||
|
* @brief caches the user display name
|
||||||
|
* @param string the internal owncloud username
|
||||||
|
* @param string the display name
|
||||||
|
*/
|
||||||
|
public function cacheUserDisplayName($ocname, $displayName) {
|
||||||
$cacheKeyTrunk = 'getDisplayName';
|
$cacheKeyTrunk = 'getDisplayName';
|
||||||
$this->connection->writeToCache($cacheKeyTrunk.$uid,$displayName);
|
$this->connection->writeToCache($cacheKeyTrunk.$ocname, $displayName);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
|
Loading…
Reference in New Issue