From c49402d26640df2adfdf3201cfc9c4c1456b7a66 Mon Sep 17 00:00:00 2001 From: Lukas Reschke Date: Thu, 9 Jun 2016 21:44:54 +0200 Subject: [PATCH] Add some error handling --- apps/files_sharing/js/files_drop.js | 24 ++++++++++++++++++++---- apps/files_sharing/templates/public.php | 7 +++++++ 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/apps/files_sharing/js/files_drop.js b/apps/files_sharing/js/files_drop.js index 3c1ccd63da..c9dafb0564 100644 --- a/apps/files_sharing/js/files_drop.js +++ b/apps/files_sharing/js/files_drop.js @@ -23,14 +23,30 @@ dirToken: $('#sharingToken').val() }, add: function(e, data) { + var errors = []; + if(data.files[0]['size'] && data.files[0]['size'] > $('#maxFilesizeUpload').val()) { + errors.push('File is too big'); + } + _.each(data['files'], function(file) { - $('#public-upload ul').append('
  • '+escapeHTML(file.name)+'
  • '); + if(errors.length === 0) { + $('#public-upload ul').append('
  • '+escapeHTML(file.name)+'
  • '); + $('[data-toggle="tooltip"]').tooltip(); + data.submit(); + } else { + OC.Notification.showTemporary(OC.L10N.translate('files_sharing', 'Could not upload "{filename}"', {filename: file.name})); + $('#public-upload ul').append('
  • '+escapeHTML(file.name)+'
  • '); + $('[data-toggle="tooltip"]').tooltip(); + + } }); - data.submit(); }, success: function (response) { - var mimeTypeUrl = OC.MimeType.getIconUrl(response['mimetype']); - $('#public-upload ul li[data-name="'+escapeHTML(response['filename'])+'"]').html(' '+escapeHTML(response['filename'])); + if(response.status !== 'error') { + var mimeTypeUrl = OC.MimeType.getIconUrl(response['mimetype']); + $('#public-upload ul li[data-name="' + escapeHTML(response['filename']) + '"]').html(' ' + escapeHTML(response['filename'])); + $('[data-toggle="tooltip"]').tooltip(); + } } }); $('#public-upload .button.icon-upload').click(function(e) { diff --git a/apps/files_sharing/templates/public.php b/apps/files_sharing/templates/public.php index ef9e4bfa57..35adb24002 100644 --- a/apps/files_sharing/templates/public.php +++ b/apps/files_sharing/templates/public.php @@ -41,6 +41,13 @@ OCP\Util::addscript('files', 'keyboardshortcuts'); +getIniWrapper()->getBytes('upload_max_filesize'); +$post_max_size = OC::$server->getIniWrapper()->getBytes('post_max_size'); +$maxUploadFilesize = min($upload_max_filesize, $post_max_size); +?> + +