mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a warning to the app:check-code if the version is missing

This commit is contained in:
Joas Schilling 2016-01-07 15:04:36 +01:00
parent 83855c073b
commit c55da1fc8d
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/command/app/checkcode.php
View File

@ -131,6 +131,10 @@ class CheckCode extends Command {
} }
}); });
$infoChecker->listen('InfoChecker', 'missingRequirement', function($minMax) use ($output) {
$output->writeln("<comment>ownCloud $minMax version requirement missing (will be an error in ownCloud 11 and later)</comment>");
});
$infoChecker->listen('InfoChecker', 'duplicateRequirement', function($minMax) use ($output) { $infoChecker->listen('InfoChecker', 'duplicateRequirement', function($minMax) use ($output) {
$output->writeln("<error>Duplicate $minMax ownCloud version requirement found</error>"); $output->writeln("<error>Duplicate $minMax ownCloud version requirement found</error>");
}); });

5
lib/private/app/codechecker/infochecker.php
View File

@ -83,13 +83,18 @@ class InfoChecker extends BasicEmitter {
'type' => 'duplicateRequirement', 'type' => 'duplicateRequirement',
'field' => 'min', 'field' => 'min',
]; ];
} else if (!isset($info['dependencies']['owncloud']['@attributes']['min-version'])) {
$this->emit('InfoChecker', 'missingRequirement', ['min']);
} }
if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && $info['requiremax']) { if (isset($info['dependencies']['owncloud']['@attributes']['max-version']) && $info['requiremax']) {
$this->emit('InfoChecker', 'duplicateRequirement', ['max']); $this->emit('InfoChecker', 'duplicateRequirement', ['max']);
$errors[] = [ $errors[] = [
'type' => 'duplicateRequirement', 'type' => 'duplicateRequirement',
'field' => 'max', 'field' => 'max',
]; ];
} else if (!isset($info['dependencies']['owncloud']['@attributes']['max-version'])) {
$this->emit('InfoChecker', 'missingRequirement', ['max']);
} }
foreach ($info as $key => $value) { foreach ($info as $key => $value) {