From c6bf51c4574453b5bb492ebf21b70d7cbe3e029b Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Wed, 13 Aug 2014 15:45:33 +0200 Subject: [PATCH] Close open file handles in files library ref #10392 --- lib/private/files/storage/common.php | 1 + lib/private/files/storage/dav.php | 1 + lib/private/files/view.php | 1 + 3 files changed, 3 insertions(+) diff --git a/lib/private/files/storage/common.php b/lib/private/files/storage/common.php index 9657b511f1..0720b8180c 100644 --- a/lib/private/files/storage/common.php +++ b/lib/private/files/storage/common.php @@ -226,6 +226,7 @@ abstract class Common implements \OC\Files\Storage\Storage { $tmpFile = \OC_Helper::tmpFile($extension); $target = fopen($tmpFile, 'w'); \OC_Helper::streamCopy($source, $target); + fclose($target); return $tmpFile; } diff --git a/lib/private/files/storage/dav.php b/lib/private/files/storage/dav.php index 02c3ebd020..ce447417d2 100644 --- a/lib/private/files/storage/dav.php +++ b/lib/private/files/storage/dav.php @@ -295,6 +295,7 @@ class DAV extends \OC\Files\Storage\Common { \OCP\Util::writeLog("webdav client", 'curl GET ' . curl_getinfo($curl, CURLINFO_EFFECTIVE_URL) . ' returned status code ' . $statusCode, \OCP\Util::ERROR); } curl_close($curl); + fclose($source); $this->removeCachedFile($target); } diff --git a/lib/private/files/view.php b/lib/private/files/view.php index 2a28e6fce8..e036bacb75 100644 --- a/lib/private/files/view.php +++ b/lib/private/files/view.php @@ -670,6 +670,7 @@ class View { $source = fopen($tmpFile, 'r'); if ($source) { $this->file_put_contents($path, $source); + fclose($source); unlink($tmpFile); return true; } else {