From c739ca3c50c19862162b6ff4644b03539c3df268 Mon Sep 17 00:00:00 2001
From: Morris Jobke <hey@morrisjobke.de>
Date: Fri, 12 Jan 2018 23:24:11 +0100
Subject: [PATCH] Fix casting in app code checker

Found while adding strict typing for PHP7+. This adds type hinting to all methods in CodeChecker.php and fixes one implicit cast.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
---
 lib/private/App/CodeChecker/CodeChecker.php | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lib/private/App/CodeChecker/CodeChecker.php b/lib/private/App/CodeChecker/CodeChecker.php
index a6368ab683..456a78aa12 100644
--- a/lib/private/App/CodeChecker/CodeChecker.php
+++ b/lib/private/App/CodeChecker/CodeChecker.php
@@ -63,8 +63,9 @@ class CodeChecker extends BasicEmitter {
 	/**
 	 * @param string $appId
 	 * @return array
+	 * @throws \RuntimeException if app with $appId is unknown
 	 */
-	public function analyse($appId) {
+	public function analyse(string $appId): array {
 		$appPath = \OC_App::getAppPath($appId);
 		if ($appPath === false) {
 			throw new \RuntimeException("No app with given id <$appId> known.");
@@ -78,7 +79,7 @@ class CodeChecker extends BasicEmitter {
 	 * @param string $folder
 	 * @return array
 	 */
-	public function analyseFolder($appId, $folder) {
+	public function analyseFolder(string $appId, string $folder): array {
 		$errors = [];
 
 		$excludedDirectories = ['vendor', '3rdparty', '.git', 'l10n', 'tests', 'test'];
@@ -106,7 +107,7 @@ class CodeChecker extends BasicEmitter {
 		foreach ($iterator as $file) {
 			/** @var SplFileInfo $file */
 			$this->emit('CodeChecker', 'analyseFileBegin', [$file->getPathname()]);
-			$fileErrors = $this->analyseFile($file);
+			$fileErrors = $this->analyseFile($file->__toString());
 			$this->emit('CodeChecker', 'analyseFileFinished', [$file->getPathname(), $fileErrors]);
 			$errors = array_merge($fileErrors, $errors);
 		}
@@ -119,7 +120,7 @@ class CodeChecker extends BasicEmitter {
 	 * @param string $file
 	 * @return array
 	 */
-	public function analyseFile($file) {
+	public function analyseFile(string $file): array {
 		$code = file_get_contents($file);
 		$statements = $this->parser->parse($code);