From c744b30b3bd610cb2b276bb274170fb6e0d03294 Mon Sep 17 00:00:00 2001 From: Sergio Bertolin Date: Thu, 3 Dec 2015 12:54:44 +0000 Subject: [PATCH] Changed fail for assertEquals and removed fields which weren't checked --- .../capabilities.feature | 3 --- .../bootstrap/CapabilitiesContext.php | 20 +++++++++++-------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/build/integration/capabilities_features/capabilities.feature b/build/integration/capabilities_features/capabilities.feature index 4adb884e80..6c1e727e7b 100644 --- a/build/integration/capabilities_features/capabilities.feature +++ b/build/integration/capabilities_features/capabilities.feature @@ -12,9 +12,6 @@ Feature: capabilities | core | webdav-root | remote.php/webdav | | | files_sharing | api_enabled | 1 | | | files_sharing | public | enabled | 1 | - | files_sharing | public | password | 1 | - | files_sharing | public | expire_date | 1 | - | files_sharing | public | send_mail | 1 | | files_sharing | public | upload | 1 | | files_sharing | resharing | 1 | | | files_sharing | federation | outgoing | 1 | diff --git a/build/integration/features/bootstrap/CapabilitiesContext.php b/build/integration/features/bootstrap/CapabilitiesContext.php index a1a14aa3bb..4e200bdf42 100644 --- a/build/integration/features/bootstrap/CapabilitiesContext.php +++ b/build/integration/features/bootstrap/CapabilitiesContext.php @@ -29,15 +29,19 @@ class CapabilitiesContext implements Context, SnippetAcceptingContext { foreach ($fd as $row) { if ($row['value'] === ''){ - $answeredValue = (string)$capabilitiesXML->$row['capability']->$row['feature']->$row['value_or_subfeature']; - if ( !$answeredValue === $row['value_or_subfeature']){ - PHPUnit_Framework_Assert::fail("Answered value $answeredValue is different to expected " . $row['value_or_subfeature']); - } + $answeredValue = (string)$capabilitiesXML->$row['capability']->$row['feature']; + PHPUnit_Framework_Assert::assertEquals( + $answeredValue, + $row['value_or_subfeature'], + "Failed field " . $row['capability'] . " " . $row['feature'] + ); } else{ - $answeredValue = (string)$capabilitiesXML->$row['capability']->$row['feature']->$row['value_or_subfeature']->$row['value']; - if ( !$answeredValue === $row['value']){ - PHPUnit_Framework_Assert::fail("Answered value $answeredValue is different to expected " . $row['value']); - } + $answeredValue = (string)$capabilitiesXML->$row['capability']->$row['feature']->$row['value_or_subfeature']; + PHPUnit_Framework_Assert::assertEquals( + $answeredValue, + $row['value'], + "Failed field: " . $row['capability'] . " " . $row['feature'] . " " . $row['value_or_subfeature'] + ); } } }