From c7d9636e82c88d30fd7346af819d303dc3d09592 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Wed, 8 Jul 2020 21:47:16 +0200 Subject: [PATCH] Kill another unneeded translation We should only translate things when we actually need them. Signed-off-by: Roeland Jago Douma --- lib/private/legacy/OC_Util.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/private/legacy/OC_Util.php b/lib/private/legacy/OC_Util.php index ae1b28d5bb..8d2bf477d5 100644 --- a/lib/private/legacy/OC_Util.php +++ b/lib/private/legacy/OC_Util.php @@ -998,23 +998,21 @@ class OC_Util { if (\OC::$server->getConfig()->getSystemValue('check_data_directory_permissions', true) === false) { return []; } - $l = \OC::$server->getL10N('lib'); - $errors = []; - $permissionsModHint = $l->t('Please change the permissions to 0770 so that the directory' - . ' cannot be listed by other users.'); + $perms = substr(decoct(@fileperms($dataDirectory)), -3); if (substr($perms, -1) !== '0') { chmod($dataDirectory, 0770); clearstatcache(); $perms = substr(decoct(@fileperms($dataDirectory)), -3); if ($perms[2] !== '0') { - $errors[] = [ + $l = \OC::$server->getL10N('lib'); + return [ 'error' => $l->t('Your data directory is readable by other users'), - 'hint' => $permissionsModHint + 'hint' => $l->t('Please change the permissions to 0770 so that the directory cannot be listed by other users.'), ]; } } - return $errors; + return []; } /**