From d00566b7501fac15e01ace70e148d1deebcc6f0c Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Sun, 26 May 2019 15:50:56 +0200 Subject: [PATCH] Don't notify admins if no potentially over exposing links found Signed-off-by: Daniel Kesselberg --- lib/private/Repair/RemoveLinkShares.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/private/Repair/RemoveLinkShares.php b/lib/private/Repair/RemoveLinkShares.php index 55b5a7c1fa..dd020dae50 100644 --- a/lib/private/Repair/RemoveLinkShares.php +++ b/lib/private/Repair/RemoveLinkShares.php @@ -201,8 +201,7 @@ class RemoveLinkShares implements IRepairStep { } } - private function repair(IOutput $output): void { - $total = $this->getTotal(); + private function repair(IOutput $output, int $total): void { $output->startProgress($total); $shareCursor = $this->getShares(); @@ -225,12 +224,13 @@ class RemoveLinkShares implements IRepairStep { } public function run(IOutput $output): void { - if ($this->shouldRun()) { - $output->info('Removing potentially over exposing link shares'); - $this->repair($output); - $output->info('Removed potentially over exposing link shares'); - } else { + if ($this->shouldRun() === false || ($total = $this->getTotal()) === 0) { $output->info('No need to remove link shares.'); + return; } + + $output->info('Removing potentially over exposing link shares'); + $this->repair($output, $total); + $output->info('Removed potentially over exposing link shares'); } }