From 7e1d14d9a596c5d36c0f625bd944e44b073d10da Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Thu, 6 Feb 2020 00:14:29 +0100 Subject: [PATCH] do not overwrite global user auth credentials with empty values Signed-off-by: Arthur Schiwon --- apps/files_external/lib/Lib/Auth/Password/UserGlobalAuth.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/apps/files_external/lib/Lib/Auth/Password/UserGlobalAuth.php b/apps/files_external/lib/Lib/Auth/Password/UserGlobalAuth.php index a0c7f91e6f..9231e5b6a4 100644 --- a/apps/files_external/lib/Lib/Auth/Password/UserGlobalAuth.php +++ b/apps/files_external/lib/Lib/Auth/Password/UserGlobalAuth.php @@ -56,6 +56,11 @@ class UserGlobalAuth extends AuthMechanism { } public function saveBackendOptions(IUser $user, $id, $backendOptions) { + // backendOptions are set when invoked via Files app + // but they are not set when invoked via ext storage settings + if(!isset($backendOptions['user']) && !isset($backendOptions['password'])) { + return; + } // make sure we're not setting any unexpected keys $credentials = [ 'user' => $backendOptions['user'],