Add tests for DirectFile and DirectHome
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma
parent
392337fa13
commit
d5222d68f0
|
|
@ -77,7 +77,7 @@ class DirectHome implements ICollection {
|
|||
$direct = $this->mapper->getByToken($name);
|
||||
|
||||
// Expired
|
||||
if ($direct->getExpiration() >= $this->timeFactory->getTime()) {
|
||||
if ($direct->getExpiration() < $this->timeFactory->getTime()) {
|
||||
throw new NotFound();
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -0,0 +1,132 @@
|
|||
<?php
|
||||
declare(strict_types=1);
|
||||
/**
|
||||
* @copyright 2018, Roeland Jago Douma <roeland@famdouma.nl>
|
||||
*
|
||||
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\DAV\Tests\Unit\Direct;
|
||||
|
||||
use OCA\DAV\Db\Direct;
|
||||
use OCA\DAV\Direct\DirectFile;
|
||||
use OCP\Files\File;
|
||||
use OCP\Files\Folder;
|
||||
use OCP\Files\IRootFolder;
|
||||
use Sabre\DAV\Exception\Forbidden;
|
||||
use Test\TestCase;
|
||||
|
||||
class DirectFileTest extends TestCase {
|
||||
|
||||
/** @var Direct */
|
||||
private $direct;
|
||||
|
||||
/** @var IRootFolder|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $rootFolder;
|
||||
|
||||
/** @var Folder|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $userFolder;
|
||||
|
||||
/** @var File|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $file;
|
||||
|
||||
/** @var DirectFile */
|
||||
private $directFile;
|
||||
|
||||
public function setUp() {
|
||||
parent::setUp();
|
||||
|
||||
$this->direct = Direct::fromParams([
|
||||
'userId' => 'directUser',
|
||||
'token' => 'directToken',
|
||||
'fileId' => 42,
|
||||
]);
|
||||
|
||||
$this->rootFolder = $this->createMock(IRootFolder::class);
|
||||
|
||||
$this->userFolder = $this->createMock(Folder::class);
|
||||
$this->rootFolder->method('getUserFolder')
|
||||
->with('directUser')
|
||||
->willReturn($this->userFolder);
|
||||
|
||||
$this->file = $this->createMock(File::class);
|
||||
$this->userFolder->method('getById')
|
||||
->with(42)
|
||||
->willReturn([$this->file]);
|
||||
|
||||
$this->directFile = new DirectFile($this->direct, $this->rootFolder);
|
||||
}
|
||||
|
||||
public function testPut() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directFile->put('foo');
|
||||
}
|
||||
|
||||
public function testGet() {
|
||||
$this->file->expects($this->once())
|
||||
->method('fopen')
|
||||
->with('rb');
|
||||
$this->directFile->get();
|
||||
}
|
||||
|
||||
public function testGetContentType() {
|
||||
$this->file->method('getMimeType')
|
||||
->willReturn('direct/type');
|
||||
|
||||
$this->assertSame('direct/type', $this->directFile->getContentType());
|
||||
}
|
||||
|
||||
public function testGetETag() {
|
||||
$this->file->method('getEtag')
|
||||
->willReturn('directEtag');
|
||||
|
||||
$this->assertSame('directEtag', $this->directFile->getETag());
|
||||
}
|
||||
|
||||
public function testGetSize() {
|
||||
$this->file->method('getSize')
|
||||
->willReturn(42);
|
||||
|
||||
$this->assertSame(42, $this->directFile->getSize());
|
||||
}
|
||||
|
||||
public function testDelete() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directFile->delete();
|
||||
}
|
||||
|
||||
public function testGetName() {
|
||||
$this->assertSame('directToken', $this->directFile->getName());
|
||||
}
|
||||
|
||||
public function testSetName() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directFile->setName('foobar');
|
||||
}
|
||||
|
||||
public function testGetLastModified() {
|
||||
$this->file->method('getMTime')
|
||||
->willReturn(42);
|
||||
|
||||
$this->assertSame(42, $this->directFile->getLastModified());
|
||||
}
|
||||
}
|
||||
|
|
@ -0,0 +1,182 @@
|
|||
<?php
|
||||
declare(strict_types=1);
|
||||
/**
|
||||
* @copyright 2018, Roeland Jago Douma <roeland@famdouma.nl>
|
||||
*
|
||||
* @author Roeland Jago Douma <roeland@famdouma.nl>
|
||||
*
|
||||
* @license GNU AGPL version 3 or any later version
|
||||
*
|
||||
* This program is free software: you can redistribute it and/or modify
|
||||
* it under the terms of the GNU Affero General Public License as
|
||||
* published by the Free Software Foundation, either version 3 of the
|
||||
* License, or (at your option) any later version.
|
||||
*
|
||||
* This program is distributed in the hope that it will be useful,
|
||||
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
* GNU Affero General Public License for more details.
|
||||
*
|
||||
* You should have received a copy of the GNU Affero General Public License
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*
|
||||
*/
|
||||
|
||||
namespace OCA\DAV\Tests\Unit\Direct;
|
||||
|
||||
use OC\Security\Bruteforce\Throttler;
|
||||
use OCA\DAV\Db\Direct;
|
||||
use OCA\DAV\Db\DirectMapper;
|
||||
use OCA\DAV\Direct\DirectFile;
|
||||
use OCA\DAV\Direct\DirectHome;
|
||||
use OCP\AppFramework\Db\DoesNotExistException;
|
||||
use OCP\AppFramework\Utility\ITimeFactory;
|
||||
use OCP\Files\IRootFolder;
|
||||
use OCP\IRequest;
|
||||
use Sabre\DAV\Exception\Forbidden;
|
||||
use Sabre\DAV\Exception\MethodNotAllowed;
|
||||
use Sabre\DAV\Exception\NotFound;
|
||||
use Test\TestCase;
|
||||
|
||||
class DirectHomeTest extends TestCase {
|
||||
|
||||
/** @var DirectMapper|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $directMapper;
|
||||
|
||||
/** @var IRootFolder|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $rootFolder;
|
||||
|
||||
/** @var ITimeFactory|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $timeFactory;
|
||||
|
||||
/** @var Throttler|\PHPUnit_Framework_MockObject_MockObject */
|
||||
private $throttler;
|
||||
|
||||
/** @var IRequest */
|
||||
private $request;
|
||||
|
||||
/** @var DirectHome */
|
||||
private $directHome;
|
||||
|
||||
public function setUp() {
|
||||
parent::setUp();
|
||||
|
||||
$this->directMapper = $this->createMock(DirectMapper::class);
|
||||
$this->rootFolder = $this->createMock(IRootFolder::class);
|
||||
$this->timeFactory = $this->createMock(ITimeFactory::class);
|
||||
$this->throttler = $this->createMock(Throttler::class);
|
||||
$this->request = $this->createMock(IRequest::class);
|
||||
|
||||
$this->timeFactory->method('getTime')
|
||||
->willReturn(42);
|
||||
|
||||
$this->request->method('getRemoteAddress')
|
||||
->willReturn('1.2.3.4');
|
||||
|
||||
$this->directHome = new DirectHome(
|
||||
$this->rootFolder,
|
||||
$this->directMapper,
|
||||
$this->timeFactory,
|
||||
$this->throttler,
|
||||
$this->request
|
||||
);
|
||||
}
|
||||
|
||||
public function testCreateFile() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directHome->createFile('foo', 'bar');
|
||||
}
|
||||
|
||||
public function testCreateDirectory() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directHome->createDirectory('foo');
|
||||
}
|
||||
|
||||
public function testGetChildren() {
|
||||
$this->expectException(MethodNotAllowed::class);
|
||||
|
||||
$this->directHome->getChildren();
|
||||
}
|
||||
|
||||
public function testChildExists() {
|
||||
$this->assertFalse($this->directHome->childExists('foo'));
|
||||
}
|
||||
|
||||
public function testDelete() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directHome->delete();
|
||||
}
|
||||
|
||||
public function testGetName() {
|
||||
$this->assertSame('direct', $this->directHome->getName());
|
||||
}
|
||||
|
||||
public function testSetName() {
|
||||
$this->expectException(Forbidden::class);
|
||||
|
||||
$this->directHome->setName('foo');
|
||||
}
|
||||
|
||||
public function testGetLastModified() {
|
||||
$this->assertSame(0, $this->directHome->getLastModified());
|
||||
}
|
||||
|
||||
public function testGetChildValid() {
|
||||
$direct = Direct::fromParams([
|
||||
'expiration' => 100,
|
||||
]);
|
||||
|
||||
$this->directMapper->method('getByToken')
|
||||
->with('longtoken')
|
||||
->willReturn($direct);
|
||||
|
||||
$this->throttler->expects($this->never())
|
||||
->method($this->anything());
|
||||
|
||||
$result = $this->directHome->getChild('longtoken');
|
||||
$this->assertInstanceOf(DirectFile::class, $result);
|
||||
}
|
||||
|
||||
public function testGetChildExpired() {
|
||||
$direct = Direct::fromParams([
|
||||
'expiration' => 41,
|
||||
]);
|
||||
|
||||
$this->directMapper->method('getByToken')
|
||||
->with('longtoken')
|
||||
->willReturn($direct);
|
||||
|
||||
$this->throttler->expects($this->never())
|
||||
->method($this->anything());
|
||||
|
||||
$this->expectException(NotFound::class);
|
||||
|
||||
$this->directHome->getChild('longtoken');
|
||||
}
|
||||
|
||||
public function testGetChildInvalid() {
|
||||
$this->directMapper->method('getByToken')
|
||||
->with('longtoken')
|
||||
->willThrowException(new DoesNotExistException('not found'));
|
||||
|
||||
$this->throttler->expects($this->once())
|
||||
->method('registerAttempt')
|
||||
->with(
|
||||
'directlink',
|
||||
'1.2.3.4'
|
||||
);
|
||||
$this->throttler->expects($this->once())
|
||||
->method('sleepDelay')
|
||||
->with(
|
||||
'1.2.3.4',
|
||||
'directlink'
|
||||
);
|
||||
|
||||
$this->expectException(NotFound::class);
|
||||
|
||||
$this->directHome->getChild('longtoken');
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue