From d548d212a25b6c77eebcd3a2bac0631b7a788281 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sat, 6 Mar 2021 01:29:54 +0100 Subject: [PATCH] Fix delete user acceptance test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adding some missing asserts showed that the "delete user" acceptance test was silently failing, as the deletion was not being confirmed in the dialog and thus the user was not being deleted. The dialog button contains a single quote ("user0's"), so the XPath expression had to be adjusted (it seems that it is not possible to escape a single quote in a string enclosed in single quotes in XPath 1.0). Signed-off-by: Daniel Calviño Sánchez --- tests/acceptance/features/bootstrap/DialogContext.php | 2 +- tests/acceptance/features/users.feature | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/acceptance/features/bootstrap/DialogContext.php b/tests/acceptance/features/bootstrap/DialogContext.php index e2dccf7b11..cbd02b3555 100644 --- a/tests/acceptance/features/bootstrap/DialogContext.php +++ b/tests/acceptance/features/bootstrap/DialogContext.php @@ -38,7 +38,7 @@ class DialogContext implements Context, ActorAwareInterface { * @return Locator */ public static function theDialogButton($text) { - return Locator::forThe()->xpath("//button[normalize-space() = '$text']")-> + return Locator::forThe()->xpath("//button[normalize-space() = \"$text\"]")-> descendantOf(self::theDialog())-> describedAs($text . " button of the dialog"); } diff --git a/tests/acceptance/features/users.feature b/tests/acceptance/features/users.feature index 2b6597b728..adb48d658f 100644 --- a/tests/acceptance/features/users.feature +++ b/tests/acceptance/features/users.feature @@ -30,6 +30,7 @@ Feature: users And I open the actions menu for the user user0 And I see that the "Delete user" action in the user0 actions menu is shown When I click the "Delete user" action in the user0 actions menu + And I click the "Delete user0's account" button of the confirmation dialog Then I see that the list of users does not contains the user user0 Scenario: disable a user