mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #12624 from nextcloud/bugfix/noid/validate-all-rich-objects 

Validate all rich objects
This commit is contained in:
Morris Jobke 2018-12-04 22:48:54 +01:00 committed by GitHub
parent f692409120 99bcc1363e
commit d8314b102e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/dav/lib/CalDAV/Activity/Provider/Base.php
View File

@ -160,7 +160,7 @@ abstract class Base implements IProvider {
}
return [
'type' => 'group',
'type' => 'user-group',
'id' => $gid,
'name' => $this->groupDisplayNames[$gid],
];

2
apps/dav/tests/unit/CalDAV/Activity/Provider/BaseTest.php
View File

@ -182,7 +182,7 @@ class BaseTest extends TestCase {
*/
public function testGenerateGroupParameter($gid) {
$this->assertEquals([
'type' => 'group',
'type' => 'user-group',
'id' => $gid,
'name' => $gid,
], $this->invokePrivate($this->provider, 'generateGroupParameter', [$gid]));

2
apps/files_sharing/lib/Activity/Providers/Groups.php
View File

@ -150,7 +150,7 @@ class Groups extends Base {
}
return [
'type' => 'group',
'type' => 'user-group',
'id' => $gid,
'name' => $this->groupDisplayNames[$gid],
];

10
lib/private/RichObjectStrings/Validator.php
View File

@ -71,11 +71,17 @@ class Validator implements IValidator {
foreach ($matches[1] as $parameter) {
if (!isset($parameters[$parameter])) {
throw new InvalidObjectExeption('Parameter is undefined');
} else {
$this->validateParameter($parameters[$parameter]);
}
}
}
foreach ($parameters as $parameter) {
if (!\is_array($parameter)) {
throw new InvalidObjectExeption('Parameter is malformed');
}
$this->validateParameter($parameter);
}
}
/**