diff --git a/core/ajax/share.php b/core/ajax/share.php index 7dd89deb8e..0dacc17d3a 100644 --- a/core/ajax/share.php +++ b/core/ajax/share.php @@ -83,7 +83,7 @@ if (isset($_POST['action']) && isset($_POST['itemType']) && isset($_POST['itemSo ($return) ? OC_JSON::success() : OC_JSON::error(); } break; - case 'informRecipients': + case 'informRecipients': $l = OC_L10N::get('core'); diff --git a/core/js/share.js b/core/js/share.js index bc5ab0a8ad..281cccaaef 100644 --- a/core/js/share.js +++ b/core/js/share.js @@ -531,13 +531,13 @@ $(document).ready(function() { }); $(document).on('click', '#dropdown .unshare', function() { - var li = $(this).parent(); + var $li = $(this).closest('li'); var itemType = $('#dropdown').data('item-type'); var itemSource = $('#dropdown').data('item-source'); - var shareType = $(li).data('share-type'); - var shareWith = $(li).data('share-with'); + var shareType = $li.data('share-type'); + var shareWith = $li.data('share-with'); OC.Share.unshare(itemType, itemSource, shareType, shareWith, function() { - $(li).remove(); + $li.remove(); var index = OC.Share.itemShares[shareType].indexOf(shareWith); OC.Share.itemShares[shareType].splice(index, 1); OC.Share.updateIcon(itemType, itemSource); @@ -549,8 +549,8 @@ $(document).ready(function() { }); $(document).on('change', '#dropdown .permissions', function() { + var li = $(this).closest('li'); if ($(this).attr('name') == 'edit') { - var li = $(this).parent().parent(); var checkboxes = $('.permissions', li); var checked = $(this).is(':checked'); // Check/uncheck Create, Update, and Delete checkboxes if Edit is checked/unck @@ -558,7 +558,6 @@ $(document).ready(function() { $(checkboxes).filter('input[name="update"]').attr('checked', checked); $(checkboxes).filter('input[name="delete"]').attr('checked', checked); } else { - var li = $(this).parent().parent().parent(); var checkboxes = $('.permissions', li); // Uncheck Edit if Create, Update, and Delete are not checked if (!$(this).is(':checked') @@ -581,8 +580,8 @@ $(document).ready(function() { }); OC.Share.setPermissions($('#dropdown').data('item-type'), $('#dropdown').data('item-source'), - $(li).data('share-type'), - $(li).data('share-with'), + li.data('share-type'), + li.data('share-with'), permissions); }); @@ -736,7 +735,7 @@ $(document).ready(function() { }); $(document).on('click', '#dropdown input[name=mailNotification]', function() { - var li = $(this).parent(); + var $li = $(this).closest('li'); var itemType = $('#dropdown').data('item-type'); var itemSource = $('#dropdown').data('item-source'); var action = ''; @@ -746,8 +745,8 @@ $(document).ready(function() { action = 'informRecipientsDisabled'; } - var shareType = $(li).data('share-type'); - var shareWith = $(li).data('share-with'); + var shareType = $li.data('share-type'); + var shareWith = $li.data('share-with'); $.post(OC.filePath('core', 'ajax', 'share.php'), {action: action, recipient: shareWith, shareType: shareType, itemSource: itemSource, itemType: itemType}, function(result) { if (result.status !== 'success') {