mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Allow chunk GC mtime tolerance for unfinished part chunks 

Whenever part chunks are written, every fwrite in the write loop will
reset the mtime to the current mtime. Only at the end will the touch()
operation set the mtime to now + ttl, in the future.

However the GC code is expecting that every chunk with mtime < now are
old and must be deleted. This causes the GC to sometimes delete part
chunks in which the write loop is slow.

To fix this, a tolerance value is added in the GC code to allow for
more time before a part chunk gets deleted.
This commit is contained in:
Vincent Petry 2016-05-17 17:03:42 +02:00
parent 56031fe155
commit dfc0a7a4a6
No known key found for this signature in database
GPG Key ID: AF8F9EFC56562186
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/private/cache/file.php vendored
View File

@ -172,7 +172,9 @@ class File implements ICache {
public function gc() { public function gc() {
$storage = $this->getStorage(); $storage = $this->getStorage();
if ($storage and $storage->is_dir('/')) { if ($storage and $storage->is_dir('/')) {
$now = time(); // extra hour safety, in case of stray part chunks that take longer to write,
// because touch() is only called after the chunk was finished
$now = time() - 3600;
$dh = $storage->opendir('/'); $dh = $storage->opendir('/');
if (!is_resource($dh)) { if (!is_resource($dh)) {
return null; return null;