From 7c07f0c7f36238c8080fc95c534a625a4f8e5fa8 Mon Sep 17 00:00:00 2001 From: Arthur Schiwon Date: Mon, 10 Aug 2020 17:34:11 +0200 Subject: [PATCH] use break not continue in switch to avoid warning Signed-off-by: Arthur Schiwon --- apps/user_ldap/lib/Group_LDAP.php | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/apps/user_ldap/lib/Group_LDAP.php b/apps/user_ldap/lib/Group_LDAP.php index 199865e762..6bf1bd31ba 100644 --- a/apps/user_ldap/lib/Group_LDAP.php +++ b/apps/user_ldap/lib/Group_LDAP.php @@ -877,8 +877,8 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I ]) ]); $ldap_users = $this->access->fetchListOfUsers($filter, $attrs, 1); - if (count($ldap_users) < 1) { - continue; + if (empty($ldap_users)) { + break; } $groupUsers[] = $this->access->dn2username($ldap_users[0]['dn'][0]); break; @@ -886,13 +886,13 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I //we got DNs, check if we need to filter by search or we can give back all of them $uid = $this->access->dn2username($member); if (!$uid) { - continue; + break; } $cacheKey = 'userExistsOnLDAP' . $uid; $userExists = $this->access->connection->getFromCache($cacheKey); if ($userExists === false) { - continue; + break; } if ($userExists === null || $search !== '') { if (!$this->access->readAttribute($member, @@ -904,7 +904,7 @@ class Group_LDAP extends BackendUtility implements GroupInterface, IGroupLDAP, I if ($search === '') { $this->access->connection->writeToCache($cacheKey, false); } - continue; + break; } $this->access->connection->writeToCache($cacheKey, true); }