From 122d1efecfec75eab6f47d8456685c6ce133dea9 Mon Sep 17 00:00:00 2001
From: Michael Gapczynski <GapczynskiM@gmail.com>
Date: Fri, 18 May 2012 10:39:43 -0400
Subject: [PATCH 1/3] Don't show the select form in the history dropdown if a
 file has no other versions

---
 apps/files_versions/js/versions.js | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/apps/files_versions/js/versions.js b/apps/files_versions/js/versions.js
index d80b95556c..8638d3ee42 100644
--- a/apps/files_versions/js/versions.js
+++ b/apps/files_versions/js/versions.js
@@ -29,13 +29,12 @@ function createVersionsDropdown(filename, files) {
 	
 	var html = '<div id="dropdown" class="drop" data-file="'+files+'">';
 	html += '<div id="private">';
-	html += '<select data-placeholder="Saved versions" id="found_versions" class="chzen-select">';
+	html += '<select data-placeholder="Saved versions" id="found_versions" class="chzen-select" style="width:16em;">';
 	html += '<option value=""></option>';
 	html += '</select>';
 	html += '</div>';
 	//html += '<input type="button" value="Revert file" onclick="revertFile()" />';
 	html += '<input type="button" value="All versions..." onclick="window.location=\''+historyUrl+'\'" name="makelink" id="makelink" />';
-	html += '<br />';
 	html += '<input id="link" style="display:none; width:90%;" />';
 	
 	if (filename) {
@@ -56,11 +55,14 @@ function createVersionsDropdown(filename, files) {
 			//alert("helo "+OC.linkTo('files_versions', 'ajax/getVersions.php'));
 			
 			if (versions) {
-				
 				$.each( versions, function(index, row ) {
 					addVersion( row );
 				});
-				
+				$('#found_versions').chosen();
+			} else {
+				$('#found_versions').hide();
+				$('#makelink').hide();
+				$('<div style="text-align:center;">No other versions available</div>').appendTo('#dropdown');
 			}
 			$('#found_versions').change(function(){
 				var revision=parseInt($(this).val());
@@ -113,6 +115,6 @@ function createVersionsDropdown(filename, files) {
 	}
 
 	$('#dropdown').show('blind');
-	$('#found_versions').chosen();
+	
 	
 }

From fcb4d2aaeea5066e8efc04f71bc2551cde18fd39 Mon Sep 17 00:00:00 2001
From: Michael Gapczynski <GapczynskiM@gmail.com>
Date: Fri, 18 May 2012 10:42:49 -0400
Subject: [PATCH 2/3] Remove the history dropdown before creating a new one

---
 apps/files_versions/js/versions.js | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/apps/files_versions/js/versions.js b/apps/files_versions/js/versions.js
index 8638d3ee42..7f3a6baf89 100644
--- a/apps/files_versions/js/versions.js
+++ b/apps/files_versions/js/versions.js
@@ -16,9 +16,17 @@ $(document).ready(function(){
 			if (scanFiles.scanning){return;}//workaround to prevent additional http request block scanning feedback
 			
 			var file = $('#dir').val()+'/'+filename;
-
-			createVersionsDropdown(filename, file)
-
+			// Check if drop down is already visible for a different file
+			if (($('#dropdown').length > 0)) {
+				if (file != $('#dropdown').data('file')) {
+					$('#dropdown').hide('blind', function() {
+						$('tr').removeClass('mouseOver');
+						createVersionsDropdown(filename, file);
+					});
+				}
+			} else {
+				createVersionsDropdown(filename, file);
+			}
 		});
 	}
 });

From ea7456a06a8934b77cb3ede753638276bacebde7 Mon Sep 17 00:00:00 2001
From: Michael Gapczynski <GapczynskiM@gmail.com>
Date: Fri, 18 May 2012 10:53:58 -0400
Subject: [PATCH 3/3] Forgot to actually call remove on the history dropdown

---
 apps/files_versions/js/versions.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/apps/files_versions/js/versions.js b/apps/files_versions/js/versions.js
index 7f3a6baf89..5e46b2a0ee 100644
--- a/apps/files_versions/js/versions.js
+++ b/apps/files_versions/js/versions.js
@@ -20,6 +20,7 @@ $(document).ready(function(){
 			if (($('#dropdown').length > 0)) {
 				if (file != $('#dropdown').data('file')) {
 					$('#dropdown').hide('blind', function() {
+						$('#dropdown').remove();
 						$('tr').removeClass('mouseOver');
 						createVersionsDropdown(filename, file);
 					});