From e19240b60bc7cfaab63fb46f5f387dcc232e2f8b Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 1 Jul 2019 15:48:26 +0200 Subject: [PATCH] Allow apps to overwrite the maximum length when reading from database Signed-off-by: Joas Schilling --- lib/private/Comments/Manager.php | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/lib/private/Comments/Manager.php b/lib/private/Comments/Manager.php index 8df4a84a47..309b682767 100644 --- a/lib/private/Comments/Manager.php +++ b/lib/private/Comments/Manager.php @@ -98,6 +98,15 @@ class Manager implements ICommentsManager { return $data; } + + /** + * @param array $data + * @return IComment + */ + public function getCommentFromData(array $data): IComment { + return new Comment($this->normalizeDatabaseData($data)); + } + /** * prepares a comment for an insert or update operation after making sure * all necessary fields have a value assigned. @@ -253,7 +262,8 @@ class Manager implements ICommentsManager { throw new NotFoundException(); } - $comment = new Comment($this->normalizeDatabaseData($data)); + + $comment = $this->getCommentFromData($data); $this->cache($comment); return $comment; } @@ -308,7 +318,7 @@ class Manager implements ICommentsManager { $resultStatement = $query->execute(); while ($data = $resultStatement->fetch()) { - $comment = new Comment($this->normalizeDatabaseData($data)); + $comment = $this->getCommentFromData($data); $this->cache($comment); $tree['replies'][] = [ 'comment' => $comment, @@ -367,7 +377,7 @@ class Manager implements ICommentsManager { $resultStatement = $query->execute(); while ($data = $resultStatement->fetch()) { - $comment = new Comment($this->normalizeDatabaseData($data)); + $comment = $this->getCommentFromData($data); $this->cache($comment); $comments[] = $comment; } @@ -455,7 +465,7 @@ class Manager implements ICommentsManager { $resultStatement = $query->execute(); while ($data = $resultStatement->fetch()) { - $comment = new Comment($this->normalizeDatabaseData($data)); + $comment = $this->getCommentFromData($data); $this->cache($comment); $comments[] = $comment; } @@ -485,7 +495,7 @@ class Manager implements ICommentsManager { $result->closeCursor(); if ($row) { - $comment = new Comment($this->normalizeDatabaseData($row)); + $comment = $this->getCommentFromData($row); $this->cache($comment); return $comment; } @@ -532,7 +542,7 @@ class Manager implements ICommentsManager { $comments = []; $result = $query->execute(); while ($data = $result->fetch()) { - $comment = new Comment($this->normalizeDatabaseData($data)); + $comment = $this->getCommentFromData($data); $this->cache($comment); $comments[] = $comment; }